Skip to content

breaking: modernize project #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

breaking: modernize project #1447

wants to merge 24 commits into from

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Apr 16, 2025 •
edited
Loading

This patch will modernize the Ionicons project, it includes the following changes:

This was referenced Apr 16, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
@christian-bromann christian-bromann marked this pull request as ready for review April 21, 2025 17:31
@christian-bromann christian-bromann requested review from a team, gnbm, brandyscarney and thetaPC and removed request for a team April 21, 2025 17:38
thetaPC
thetaPC requested changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cheat sheet has broken links when clicking on an icon, might be worth fixing.

It might beneficial to add more comments of what's going on. We don't often work in this repo so comments would be a nice refresher.

@christian-bromann
Copy link
Member Author

@thetaPC thanks for reviewing your changes. I addressed the issues:

  • added prettier commands to package.json
  • added a copy output target to the www output target to properly copy over the SVGs
  • updated CONTRIBUTING.md and CoC files
  • added comments to icon.tsx

Let me know if you have further feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC requested changes

@gnbm gnbm Awaiting requested review from gnbm gnbm was automatically assigned from ionic-team/framework

@brandyscarney brandyscarney Awaiting requested review from brandyscarney

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christian-bromann @thetaPC