Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #188

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix tests #188

wants to merge 3 commits into from

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Mar 30, 2023

WHAT

🤖 Generated by Copilot at 1eb2d64

Improve and update tests for sample 3 workspace. Refactor test code with tryFindLoadedProject helper function.

🤖 Generated by Copilot at 1eb2d64

We're testing the sample 3 workspace, me hearties
With F# and C# projects galore
We'll use tryFindLoadedProject to check the assertions
And update the notifications and more

🧪🔄🎨

WHY

Trying to fix those pesky tests in CI.
They keep me asking, why why why.

HOW

🤖 Generated by Copilot at 1eb2d64

  • Add tryFindLoadedProject function to simplify and improve test assertions for finding loaded projects in notifications (link)
  • Refactor testSample3 function to use tryFindLoadedProject instead of brittle pattern matching on notifications list (link)
  • Update expected notifications for testSample3GraphExpected list to match the actual order and number of notifications from the project graph loader (link)
  • Enable testSample3 function for both workspace loader and project graph loader implementations, as the new test suite and tryFindLoadedProject function have resolved the previous issues (link)
  • Enable solution tests and render tests for sample 3 workspace, as the new test suite and the fixes to the project graph loader have resolved the previous issues (link)

@TheAngryByrd TheAngryByrd force-pushed the lets-fix-some-tests branch 5 times, most recently from 1fbb98b to 6607a31 Compare March 30, 2023 01:23
maybe plz
@TheAngryByrd TheAngryByrd force-pushed the lets-fix-some-tests branch 4 times, most recently from 4cbaa7f to e269543 Compare March 30, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant