Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust glider search #104

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Robust glider search #104

merged 4 commits into from
Jan 29, 2025

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 28, 2025

@marysolokas reported that an extensive query leads to multiple 503 errors. In this PR we implement a retrying mechanism to try to circumvent that. Hopefully we can manage to be easy on the server while still retrieving all the data needed for the metrics.

@ocefpaf ocefpaf marked this pull request as ready for review January 29, 2025 08:43
@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 29, 2025

This one is good to go! We should mint a new release after the merge so @marysolokas can run the metrics again.

@ocefpaf ocefpaf requested a review from MathewBiddle January 29, 2025 09:05
Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MathewBiddle MathewBiddle merged commit a1e2dec into ioos:main Jan 29, 2025
4 checks passed
@ocefpaf ocefpaf deleted the robust_glider_search branch January 29, 2025 17:12
@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 29, 2025

@MathewBiddle do you mind minting a new release? I don't have the right permissions here to do it.

@MathewBiddle
Copy link
Contributor

on [v0.5.0](https://github.com/ioos/ioos_metrics/releases/tag/v0.5.0)?

@MathewBiddle
Copy link
Contributor

done. See https://github.com/ioos/ioos_metrics/releases/tag/v0.6.0

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 29, 2025

@marysolokas, once you update to ioos-metrics 0.6.0 you should be able to re-run the glider metrics script. Let me know if that works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants