-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glider names #90
Fix glider names #90
Conversation
Looks like a lot of linting happening here. This will take me a minute to decipher the actual changes. |
I think this is the change your proposing in |
Yep. That is the main part of this PR. The rest is mostly lint auto-updates. |
Okay. That change looks good. I ran into another issue with the IOOS_BTN.ipynb: Looks like Here is what I'm running: >>pd.__version__
'2.2.1' Suggest changing to if today not in ioos_btn_df["date_UTC"].to_list():
ioos_btn_df = pd.concat([ioos_btn_df, pd.DataFrame({"date_UTC": [today]})]) |
Do you want to fix that in this PR? Is that version of the notebook that uses the ioos_metrics library? |
ah, good point. I got confused. Nah, lets fix that when we get around to #35 |
I should have been testing with https://github.com/ioos/ioos_metrics/blob/main/notebooks/run_metrics.ipynb. Still looks good. Merging. |
The renaming of that one to IOOS_BTN.ipynb is still pending your approval 😬 |
@MathewBiddle, this fix an issue reported by Mary Solokas (I'm not sure what is Mary's GitHub handle). After review/merge we should issued a new release.