Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glider names #90

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Fix glider names #90

merged 5 commits into from
Oct 4, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 3, 2024

@MathewBiddle, this fix an issue reported by Mary Solokas (I'm not sure what is Mary's GitHub handle). After review/merge we should issued a new release.

@MathewBiddle
Copy link
Contributor

Looks like a lot of linting happening here. This will take me a minute to decipher the actual changes.

@MathewBiddle
Copy link
Contributor

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 4, 2024

I think this is the change your proposing in ioos_metrics.py?

https://github.com/ioos/ioos_metrics/pull/90/files#diff-c1e3298f59885519b1b10f023299eae49fedc0616aaf818f2155ed5a11a5371b

Yep. That is the main part of this PR. The rest is mostly lint auto-updates.

@MathewBiddle
Copy link
Contributor

Okay. That change looks good.

I ran into another issue with the IOOS_BTN.ipynb:

image

Looks like .append has been deprecated since pandas 1.4: https://pandas.pydata.org/pandas-docs/version/1.4/reference/api/pandas.DataFrame.append.html

Here is what I'm running:

>>pd.__version__
'2.2.1'

Suggest changing to pd.concat:

if today not in ioos_btn_df["date_UTC"].to_list():
    ioos_btn_df = pd.concat([ioos_btn_df, pd.DataFrame({"date_UTC": [today]})])

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 4, 2024

I ran into another issue with the IOOS_BTN.ipynb

Do you want to fix that in this PR? Is that version of the notebook that uses the ioos_metrics library?

@MathewBiddle
Copy link
Contributor

ah, good point. I got confused. Nah, lets fix that when we get around to #35

@MathewBiddle
Copy link
Contributor

I should have been testing with https://github.com/ioos/ioos_metrics/blob/main/notebooks/run_metrics.ipynb.

Still looks good. Merging.

@MathewBiddle MathewBiddle merged commit d3315d9 into ioos:main Oct 4, 2024
4 checks passed
@ocefpaf ocefpaf deleted the fix_glider_names branch October 4, 2024 15:14
@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 4, 2024

I should have been testing with https://github.com/ioos/ioos_metrics/blob/main/notebooks/run_metrics.ipynb.

The renaming of that one to IOOS_BTN.ipynb is still pending your approval 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants