image suggestions box not being filtered in the "All" section of google search

[STUAAAAAAAAAART]

Expected Behavior

image suggestions box (not the image search section, that's working) also getting filtered and blacklist items hidden in there

Actual Behavior

image suggestions box not being filtered in the "all" section of google search

sites in that box exist in the filter list

Steps to Reproduce the Problem

1. ensure filter(s) in ublacklist contain *://*.prompthunt.com/*
2. google search for pixar jean baptiste
   (i know that's not how jon batiste's name spelt, i'm going off memory and couldn't recall)

i'm not sure of other terms that would produce that scenario as well, but that search result seems to be consistent at the moment

Specifications

• Browser: Google Chrome 124.0.6367.203 (Official Build) (64-bit)
• Other extensions/add-ons:
  • uBlock Origin 1.57.0
  • dark reader 4.9.84
  • Google IBA Opt-Out 1.5

• Search engine: google
• Language: english
• Region: SG

any other comments

it's google's loosening grip on quality and abstracting away user-sided control that i have to resort to using this extension. thanks for making it work for the most part

[aug-dev]

I'll look into this once I finish working on another feature.

[aug-dev]

Adding a rule to support this was surprisingly simple... but there is a problem.

If we click the button to load more images, they slip through the rule and show up anyways:

img-blocking-demo.webm

Something similar happens when the "Images" section doesn't show up in the first page (before auto-loading new content.)

This seems to be an issue with the extension currently, where the ability to detect dynamic content can be hit or miss sometimes (e.g. #446).

This is not a trivial problem to solve (at least I think), but I can tell that is something we are aware of.

[iorate]

We can use pagerHandlers to extract search results from dynamically added elements.

ublacklist/src/scripts/search-engines/google-desktop.ts

Lines 469 to 489 in 4a9a5e0

	pagerHandlers: [
	// People Also Ask
	{
	target: '.IZE3Td, [jsname="Cpkphb"]',
	innerTargets: ".g",
	},
	// Recipe, Regular (COVID-19), Web Result (COVID-19), ...
	{
	target: ".yl > div",
	innerTargets:
	".YwonT, [data-snf], [data-sokoban-feature], [data-content-feature], .IsZvec, .kno-fb-ctx, .ZE0LJd, .S1FAPd, .g, .F9rcV, .hMJ0yc",
	},
	// AutoPagerize and Continuous scrolling (US)
	{
	target: '.autopagerize_page_info ~ div, [id^="arc-srp"] > div',
	// Regular, Video, and YouTube and TikTok channel
	innerTargets:
	"[data-snf], [data-sokoban-feature], [data-content-feature], .IsZvec, .g, .iHxmLe, .d3zsgb, .rULfzc",
	},
	],
	}),

[aug-dev]

Oh wow!

Not going to lie, I hadn't yet deciphered what pageHandlers were used for. 😅

This is cool! I was trying to fix this issue right now, later this day I'll look into it.

[aug-dev]

Here's the PR solving this issue #467

:)

[github-actions]

🎉 This issue has been resolved in version 8.7.0 🎉

The release is available on:

• Chrome Web Store
• Firefox Add-ons
• GitHub release

Your semantic-release bot 📦🚀