Fix Extension Behavior On Unsupported udm Values #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an udm value was present but not supported by the extension, uBlacklist would not return any serpHandler on Google Desktop.
aug-dev
changed the title
aug-dev
changed the title
iorate
approved these changes
May 26, 2024
|
🎉 This PR is included in version 8.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves an issue reported on #465 where uBlacklist was not working on Google's new "Web" filter. (More details on the bug report.)
This was happening because, previously, if an
udmvalue was present in a Google URL but its number was not supported by the extension (such as 14), uBlacklist would not return anyserpHandleron Google Desktop.Now, instead, if an
udmvalue is present but not supported, thetbmis used instead. (Like the code was trying to do before.)