This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
RFC: Tangle API #23
Open
RFC: Tangle API #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Oct 28, 2019
tsvisabo
approved these changes
Oct 29, 2019
|
Considerations (mostly for my benefit):
|
tsvisabo
previously approved these changes
Nov 13, 2019
text/0000-tangle/0000-tangle.md
Outdated
| let vertices = &mut self.vertices; | ||
| let txs_to_approvers = &self.txs_to_approvers; | ||
|
|
||
| // The algorithm is recursive, but we don't want to use the stack |
There was a problem hiding this comment.
this comment is confusing since we are using a stack :)
There was a problem hiding this comment.
I should definitely clarify what I mean by that comment.
* Initial commit * Added Drawbacks, Rationale and Unresolved questions sections * Fixed tryte string example * Addressed ternary issues, renamed RFC document * Encoding information, fixed shortened phrases, minor formatting changes * Simplified example with new API features, minor fixes * Removed 'we' from ternary RFC * Consistent punctuation in ternary RFC * Extra encoding information for Trits and TritBuf * Added zero-cost explanation * Updated feature name * Fixed URL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered