-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ed25519 tests #54
Conversation
* Added Malleability test case. * Added zip215 tests. * Added ed25519 sign.input tests. * Removed TODO that is not needed.
Copying @Wollac's comment from previous PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix Clippy (even though it isn't your fault, its because of rust 1.50.0) - this is open source gardening :D
Clippy fixed here: https://github.com/iotaledger/crypto.rs/pull/52/files#diff-eb22024a611ef759fe3cbefcf751bf535d92d3154fc0e6641944cda7a82f654b
and also add a changefile:
https://github.com/iotaledger/crypto.rs/tree/dev/.changes
For the reviewers: I have spoken with @melatron and he will setup gpg signing for his next PRs. I will sign off for this PR. |
@Wollac About your questions from - #53 (comment) The idea of leaving the tests there is that in Rust you write integration tests in the /tests folder and unit tests under the file for the specific functionality you are testing. For the tests that are in |
OK, fair enough. I was mainly wondering that they are kind of redundant or duplicates with the new reference test vectors. Let's leave them in then! more tests hardly ever hurt 🙂 |
Description of change
Type of change
How the change has been tested
All existing and new tests pass.
Change checklist