feat: Improve rendering of error messages when they are JS objects (#…

…7548) * feat: Improve rendering of error messages when they are JS objects * feat: Improve stringifying the Error when it's logged through BaseError * fix: Improve renderError to stringify only if object to prevent "double quotes" --------- Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
iotaledger · Oct 17, 2023 · 607f6d8 · 607f6d8
1 parent cca66a1
commit 607f6d8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/packages/desktop/components/popups/ErrorLogPopup.svelte b/packages/desktop/components/popups/ErrorLogPopup.svelte
@@ -24,9 +24,12 @@
 
     function renderErrorMessage(message: string): string {
         if (message !== null && typeof message === 'object') {
-            return JSON.stringify(message)
+            try {
+                return JSON.stringify(message)
+            } catch {
+                return message
+            }
         }
-
         return message
     }
 </script>

diff --git a/packages/shared/lib/core/error/classes/base-error.class.ts b/packages/shared/lib/core/error/classes/base-error.class.ts
@@ -21,8 +21,15 @@ export class BaseError extends Error {
         }
 
         if (params?.saveToErrorLog) {
-            const logMessage = String(params?.originalError) ?? message
-            addError({ ...params, message: logMessage, type: 'BaseError', time: Date.now() })
+            let logMessage
+            if (params?.originalError) {
+                try {
+                    logMessage = JSON.stringify(params.originalError)
+                } catch {
+                    logMessage = message
+                }
+            }
+            addError({ ...params, message: logMessage ?? message, type: 'BaseError', time: Date.now() })
         }
 
         if (params?.showNotification) {