Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add path aliases to shared folder #7667

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Oct 26, 2023

Summary

Update paths in tsconfig.base in shared folder to type check component props correctly
Closes #7666

Changelog

- Update paths in tsconfig.base in shared folder to type check component props correctly

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@VmMad VmMad requested review from evavirseda and cpl121 October 26, 2023 11:12
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@begonaalvarezd begonaalvarezd changed the title fix: update paths in tsconfig for shared folder chore: add path aliases to shared folder Nov 2, 2023
@begonaalvarezd begonaalvarezd merged commit 34bd6ee into develop Nov 2, 2023
@begonaalvarezd begonaalvarezd deleted the fix/shared/tsconfig-aliases branch November 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add aliases to the shared folder
4 participants