-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce ledger polling on heavy duty work like recover accounts #7715
Merged
begonaalvarezd
merged 7 commits into
develop
from
feat/reduce-ledger-polling-heavy-work
Nov 17, 2023
Merged
feat: reduce ledger polling on heavy duty work like recover accounts #7715
begonaalvarezd
merged 7 commits into
develop
from
feat/reduce-ledger-polling-heavy-work
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
requested changes
Nov 14, 2023
cpl121
previously requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, but I think it would be interesting to also add it to the shimmer claiming
marc2332
requested changes
Nov 17, 2023
packages/shared/lib/core/ledger/actions/pollLedgerNanoStatus.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/ledger/actions/pollLedgerNanoStatus.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/ledger/actions/pollLedgerNanoStatus.ts
Outdated
Show resolved
Hide resolved
marc2332
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry
packages/shared/lib/core/ledger/actions/pollLedgerNanoStatus.ts
Outdated
Show resolved
Hide resolved
marc2332
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #7714
Changelog
Testing
Platforms
Instructions
...
Checklist