feat: update dev tools to network upgrade: Mint NFT #8115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of github.com:iotaledger/firefly into feat/update-dev-tools-mint-nft
…feat/update-dev-tools-mint-nft
… of github.com:iotaledger/firefly into feat/update-dev-tools-mint-nft
… of github.com:iotaledger/firefly into feat/update-dev-tools-mint-nft
packages/shared/lib/core/nfts/constants/default-nft-entry-key.constant.ts
Outdated
Show resolved
Hide resolved
marc2332
requested changes
Mar 5, 2024
| @@ -13,24 +18,32 @@ import { | |||
| import { NftActivity } from '../types' | |||
| import { getDefaultTransactionOptions, preprocessOutgoingTransaction } from '../utils' | |||
| import { generateSingleNftActivity } from '../utils/generateActivity/generateSingleNftActivity' | |||
| import { plainToInstance } from 'class-transformer' | |||
|
|
|||
| // TODO: Modify this temporary interface | |||
There was a problem hiding this comment.
Shouldn't we maybe link an issue here too?
There was a problem hiding this comment.
he means adding the issue inside the code too in the TODO so you can go back to it
There was a problem hiding this comment.
something like
Suggested change
| // TODO: Modify this temporary interface | |
| // TODO: Update this temporary interface when fixed in the SDK, linked issue https://github.com/iotaledger/firefly/issues/8134 |
|
|
||
| export function getMetadataFromNftOutput(output: NftOutput): string { | ||
| const metadata = output.immutableFeatures?.find( | ||
| (feature) => feature.type === FeatureType.Metadata | ||
| ) as MetadataFeature | ||
| return metadata?.data | ||
| // TODO: update this to return all entries |
There was a problem hiding this comment.
same here, this can link to the gh issue so we know what to update later on and which issue to link
begonaalvarezd
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7867
TODO comment -> #8120
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist