Skip to content

fix: compilation error #4568

fix: compilation error

fix: compilation error #4568

Triggered via pull request November 27, 2024 04:59
Status Failure
Total duration 3m 29s
Artifacts

clippy.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
this expression creates a reference which is immediately dereferenced by the compiler: identity_iota_core/src/document/iota_document.rs#L424
error: this expression creates a reference which is immediately dereferenced by the compiler --> identity_iota_core/src/document/iota_document.rs:424:43 | 424 | let unpacked = unpack_identity_data(&did, data).map_err(|_| { | ^^^^ help: change this to: `did` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this expression creates a reference which is immediately dereferenced by the compiler: identity_iota_core/src/document/iota_document.rs#L440
error: this expression creates a reference which is immediately dereferenced by the compiler --> identity_iota_core/src/document/iota_document.rs:440:89 | 440 | Self::from_iota_document_data(multi_controller.controlled_value(), allow_empty, &did, created, updated)?; | ^^^^ help: change this to: `did` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: identity_iota_core/src/document/iota_document.rs#L454
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> identity_iota_core/src/document/iota_document.rs:454:13 | 454 | data: &Vec<u8>, | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
this expression creates a reference which is immediately dereferenced by the compiler: identity_iota_core/src/document/iota_document.rs#L469
error: this expression creates a reference which is immediately dereferenced by the compiler --> identity_iota_core/src/document/iota_document.rs:469:80 | 469 | .and_then(|state_metadata_doc| state_metadata_doc.into_iota_document(&did))? | ^^^^ help: change this to: `did` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
very complex type used. Consider factoring parts into `type` definitions: identity_iota_core/src/rebased/migration/identity.rs#L379
error: very complex type used. Consider factoring parts into `type` definitions --> identity_iota_core/src/rebased/migration/identity.rs:379:6 | 379 | ) -> Result<Option<(UID, Multicontroller<Vec<u8>>, Timestamp, Timestamp)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-D clippy::type-complexity` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
missing documentation for a module: identity_iota_core/src/lib.rs#L34
error: missing documentation for a module --> identity_iota_core/src/lib.rs:34:1 | 34 | pub mod rebased; | ^^^^^^^^^^^^^^^ | = note: `-D missing-docs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(missing_docs)]`
unreachable `pub` item: identity_iota_core/src/document/iota_document.rs#L398
error: unreachable `pub` item --> identity_iota_core/src/document/iota_document.rs:398:1 | 398 | pub mod client_document { | ---^^^^^^^^^^^^^^^^^^^^ | | | help: consider restricting its visibility: `pub(crate)` | = help: or consider exporting it for use by other crates = note: `-D unreachable-pub` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unreachable_pub)]`
missing documentation for a module: identity_iota_core/src/rebased/mod.rs#L4
error: missing documentation for a module --> identity_iota_core/src/rebased/mod.rs:4:1 | 4 | pub mod assets; | ^^^^^^^^^^^^^^
missing documentation for a module: identity_iota_core/src/rebased/mod.rs#L5
error: missing documentation for a module --> identity_iota_core/src/rebased/mod.rs:5:1 | 5 | pub mod client; | ^^^^^^^^^^^^^^
missing documentation for a module: identity_iota_core/src/rebased/mod.rs#L7
error: missing documentation for a module --> identity_iota_core/src/rebased/mod.rs:7:1 | 7 | pub mod migration; | ^^^^^^^^^^^^^^^^^
clippy
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/[email protected]. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/