Fix issuer claim check in VC #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
added
Wasm
PhilippGackstatter
approved these changes
Sep 20, 2023
abdulmth
commented
Sep 20, 2023
eike-hass
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JWT VC is validated,
check_consistencywill be called that checks if values are duplicated in the JWT claims and the VC itself in thevcclaim. These values will be copied afterward whenCredentialis created after decoding.This works fine for all the claims except
iss. It's not checked for consistency and it will be copied to thepropertiesfield inCredentialinstead ofissuer. This PR fixes that and adds some tests.I expect similar issues in JWT VP. I will take a look and eventually open another PR.