Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to specific revisions and tags in Cargo.toml files #1434

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

itsyaasir
Copy link
Contributor

@itsyaasir itsyaasir commented Nov 21, 2024

Description of change

This PR pins the iota dependencies to the testnet revision.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir added the No changelog Excludes PR from becoming part of any changelog label Nov 21, 2024
@itsyaasir itsyaasir self-assigned this Nov 21, 2024
@itsyaasir itsyaasir requested a review from a team as a code owner November 21, 2024 17:23
@eike-hass eike-hass changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 22, 2024 17:18
@eike-hass eike-hass changed the base branch from feat/identity-rebased-alpha to feat/identity-rebased November 22, 2024 17:19
@itsyaasir itsyaasir changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 25, 2024 13:19
@itsyaasir itsyaasir closed this Nov 26, 2024
@itsyaasir itsyaasir reopened this Nov 26, 2024
@itsyaasir itsyaasir requested a review from a team November 26, 2024 11:35
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsyaasir shouldn't we use a proper release for iota-sdk? Like 0.7.2-rc?

@itsyaasir
Copy link
Contributor Author

@itsyaasir shouldn't we use a proper release for iota-sdk? Like 0.7.2-rc?

Yeah, that would be the ideal way but unfortunately the tag is still using ssh dependency which is bringing problem with authentication, I will be tracking this and will update with the appropriate tag when the ssh deps are removed.

@itsyaasir itsyaasir merged commit a307b36 into feat/identity-rebased-alpha Nov 26, 2024
1 check passed
@itsyaasir itsyaasir deleted the chore/update-deps branch November 26, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants