Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for REST API, RMC and visualizer #444

Merged
merged 18 commits into from
Oct 19, 2023
Merged

Fixes for REST API, RMC and visualizer #444

merged 18 commits into from
Oct 19, 2023

Conversation

daria305
Copy link
Contributor

@daria305 daria305 commented Oct 18, 2023 •
edited by jkrvivian
Loading

Set of fixes regarding REST API (some of them identified in issue #206):

  • Retain errors from BlockFiltered event.
    • Block can be filtered out after it's attached to the BlockDAG, the failure reason should be kept and can be checked via BlockMetadata api.
  • RMC used for mana burn calculation should be from the same slot as commitment of the block, fixes in REST api and commitment filter
  • add missing RMC in evilspammer block building, and set maxBurnedMana correctly
  • extend BlockIssuance endpoint with optional query param slotIndex, we need it to make sure both responses: congestion and blockIssuance should point to the same slot (as RMC uses slot index of the commitment)
  • visualizer fixes

This PR is based on iotaledger/iota.go#572

@daria305 daria305 mentioned this pull request Oct 18, 2023
Merged
@daria305 daria305 changed the title Fixes for REEST API, RMC and visualizer Fixes for REST API, RMC and visualizer Oct 19, 2023
jkrvivian
jkrvivian suggested changes Oct 19, 2023
View reviewed changes
components/restapi/core/accounts.go Outdated Show resolved Hide resolved
@daria305
Add RMC method for commitment and use it in REST API
8c2dcad
@daria305
Merge branch 'develop' into debug/metadata
7579bc0 
# Conflicts:
#	go.mod
#	go.sum
#	tools/evil-spammer/go.mod
#	tools/evil-spammer/go.sum
#	tools/gendoc/go.mod
#	tools/gendoc/go.sum
#	tools/genesis-snapshot/go.mod
#	tools/genesis-snapshot/go.sum
@daria305
Update go mod for iotago
29ed31d
@daria305 daria305 requested a review from jkrvivian October 19, 2023 10:38
karimodm
karimodm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@karimodm karimodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karimodm karimodm merged commit 926bf11 into develop Oct 19, 2023
5 checks passed
@karimodm karimodm deleted the debug/metadata branch October 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrvivian jkrvivian jkrvivian approved these changes

@karimodm karimodm karimodm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daria305 @karimodm @jkrvivian