Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align naming: structure to parameters #564

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Align naming: structure to parameters #564

merged 15 commits into from
Oct 18, 2023

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Oct 10, 2023 •
edited by jkrvivian
Loading

  • rentParameters -> StorageScoreParameters
  • rentStructure -> StorageScoreStructure
  • manaStructure -> manaParameters
  • workScoreStructure -> workScoreParameters
  • Remove ValidatorBlockPerSlot from RewardParameters

original PR was auto closed because of base branch deletion #559

@jkrvivian jkrvivian mentioned this pull request Oct 18, 2023
Merged
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@cyberphysic4l cyberphysic4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the rent.go to storageScore.go

cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
api_test.go Outdated Show resolved Hide resolved
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
rent_test.go Outdated Show resolved Hide resolved
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
rent_test.go Outdated Show resolved Hide resolved
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
rent.go Outdated Show resolved Hide resolved
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
rent.go Outdated Show resolved Hide resolved
cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@cyberphysic4l cyberphysic4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 6862 name of the test to be updated to remove StorageScore prefix

cyberphysic4l
cyberphysic4l reviewed Oct 18, 2023
View reviewed changes
tpkg/util.go Outdated Show resolved Hide resolved
@cyberphysic4l cyberphysic4l merged commit 0d7c762 into develop Oct 18, 2023
4 checks passed
@cyberphysic4l cyberphysic4l deleted the info-resp-naming branch October 18, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberphysic4l cyberphysic4l cyberphysic4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muXxer @cyberphysic4l @jkrvivian