test_and_benchmark

Fixed SignedTransaction.ID() #2656

Sign in to view logs

This check has been archived and is scheduled for deletion. Learn more about checks retention

GitHub Actions / golangci failed Oct 10, 2023 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (7)

merklehasher/merkle_proof.go|152 col 24| func (*ValueHash[V]).hash is unused (unused)
merklehasher/merkle_proof.go|156 col 23| func (*LeafHash[V]).hash is unused (unused)
merklehasher/merkle_proof.go|160 col 19| func (*Node[V]).hash is unused (unused)
commitment_roots.go|78 col 95| BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
output_id_proof.go|29 col 76| BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
output_id_proof.go|73 col 76| BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
transaction.go|98 col 76| BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)

Filtered Findings (0)

Annotations

Check failure on line 152 in merklehasher/merkle_proof.go

github-actions / golangci

[golangci] merklehasher/merkle_proof.go#L152

func `(*ValueHash[V]).hash` is unused (unused)

Raw output


            merklehasher/merkle_proof.go:152:24: func `(*ValueHash[V]).hash` is unused (unused)
func (l *ValueHash[V]) hash(_ *Hasher[V]) []byte {
                       ^

Check failure on line 156 in merklehasher/merkle_proof.go

github-actions / golangci

[golangci] merklehasher/merkle_proof.go#L156

func `(*LeafHash[V]).hash` is unused (unused)

Raw output


            merklehasher/merkle_proof.go:156:23: func `(*LeafHash[V]).hash` is unused (unused)
func (h *LeafHash[V]) hash(_ *Hasher[V]) []byte {
                      ^

Check failure on line 160 in merklehasher/merkle_proof.go

github-actions / golangci

[golangci] merklehasher/merkle_proof.go#L160

func `(*Node[V]).hash` is unused (unused)

Raw output


            merklehasher/merkle_proof.go:160:19: func `(*Node[V]).hash` is unused (unused)
func (p *Node[V]) hash(hasher *Hasher[V]) []byte {
                  ^

Check failure on line 78 in commitment_roots.go

github-actions / golangci

[golangci] commitment_roots.go#L78

BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)

Raw output


            commitment_roots.go:78:95: BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
	if !lo.PanicOnErr(proof.ContainsValue(proofedRoot, merklehasher.NewHasher[Identifier](crypto.BLAKE2b_256))) {
	                                                                                             ^

Check failure on line 29 in output_id_proof.go

github-actions / golangci

[golangci] output_id_proof.go#L29

BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)

Raw output


            output_id_proof.go:29:76: BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
	outputHasher := merklehasher.NewHasher[*APIByter[TxEssenceOutput]](crypto.BLAKE2b_256)
	                                                                          ^

Check failure on line 73 in output_id_proof.go

github-actions / golangci

[golangci] output_id_proof.go#L73

BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)

Raw output


            output_id_proof.go:73:76: BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
	outputHasher := merklehasher.NewHasher[*APIByter[TxEssenceOutput]](crypto.BLAKE2b_256)
	                                                                          ^

Check failure on line 98 in transaction.go

github-actions / golangci

[golangci] transaction.go#L98

BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)

Raw output


            transaction.go:98:76: BLAKE2b_256 contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
	outputHasher := merklehasher.NewHasher[*APIByter[TxEssenceOutput]](crypto.BLAKE2b_256)
	                                                                          ^

View more details on GitHub Actions