Merge branch 'develop' into sc-platform/ensure-Move-2024-and-Enums-do…

…cumented

.changeset/config.json

@@ -12,7 +12,6 @@
 		"iota-wallet",
 		"iota-explorer",
 		"wallet-dashboard",
-		"@iota/apps-ui-kit",
 		"apps-backend",
 		"@iota/core",
 		"@iota/apps-ui-kit",

.github/CODEOWNERS

@@ -36,7 +36,6 @@
 
 # core-consensus team
 /consensus/ @iotaledger/core-consensus
-/narwhal/ @iotaledger/core-consensus
 
 # dev-tools team
 /crates/iota/ @iotaledger/dev-tools
@@ -62,22 +61,25 @@ prettier.config.js @iotaledger/boxfish @iotaledger/tooling
 turbo.json @iotaledger/boxfish @iotaledger/tooling
 vercel.json @iotaledger/boxfish @iotaledger/tooling
 
-# Docs are for DevEx to approve upon
+# Docs and examples are for DevEx to approve upon
 /docs/ @iotaledger/devx
+/examples/ @iotaledger/devx
+
 # Override ownership of Boxfish Studio and the tooling team for the following files
 /docs/**/package.json @iotaledger/devx
 /docs/**/vercel.json @iotaledger/devx
 
 # CI Taskforce
-/.github/actions/ @msarcev @alexsporn @thibault-martinez @DaughterOfMars @fijter @Dr-Electron
-/.github/workflows/ @msarcev @alexsporn @thibault-martinez @DaughterOfMars @fijter @Dr-Electron
+/.github/actions/ @msarcev @alexsporn @thibault-martinez @DaughterOfMars @Dr-Electron
+/.github/workflows/ @msarcev @alexsporn @thibault-martinez @DaughterOfMars @Dr-Electron
 
 # Protect this CODEOWNERS file, with some fallback in case of unavailability
-/.github/CODEOWNERS @luca-moser @lzpap @miker83z @fijter
+/.github/CODEOWNERS @luca-moser @lzpap @miker83z @alexsporn
 
 # Scripts
 /scripts/dependency_graphs/ @muXxer
 /scripts/cargo_sort/ @muXxer
+/scripts/generate_files/ @muXxer
 /scripts/codesearch/ @muXxer
 /scripts/slipstream/ @muXxer
 

.github/ISSUE_TEMPLATE/release.md

@@ -10,7 +10,6 @@ title: '[Task(*)]: release version x.y.z'
 - [ ] Edit `crates/iota-open-rpc/spec/openrpc.json`
 - [ ] Update `sdk/typescript/src/version.ts` (`pnpm sdk build`)
 - [ ] Update `Cargo.lock` (`cargo check`)
-- [ ] Update `crates/iota-framework/packages/deepbook/Move.lock`
 - [ ] Update `crates/iota-framework/packages/iota-framework/Move.lock`
 - [ ] Update `crates/iota-framework/packages/iota-system/Move.lock`
 - [ ] Update `crates/iota-framework/packages/move-stdlib/Move.lock`

.github/actions/diffs/action.yml

@@ -27,7 +27,6 @@ runs:
             - "consensus/**"
             - "crates/**"
             - "external-crates/**"
-            - "narwhal/**"
             - "iota-execution/**"
             - "docs/examples/rust/**"
             - ".github/workflows/hierarchy.yml"
@@ -64,6 +63,5 @@ runs:
             - "docker/**"
             - "external-crates/**"
             - "kiosk/**"
-            - "narwhal/**"
             - "nre/**"
             - "iota-execution/**"

.github/crates-filters.yml

@@ -170,16 +170,6 @@ typed-store-derive:
   - "crates/typed-store-derive/**"
 typed-store-error:
   - "crates/typed-store-error/**"
-narwhal-config:
-  - "narwhal/config/**"
-narwhal-crypto:
-  - "narwhal/crypto/**"
-narwhal-network:
-  - "narwhal/network/**"
-narwhal-test-utils:
-  - "narwhal/test-utils/**"
-narwhal-types:
-  - "narwhal/types/**"
 iota-execution:
   - "iota-execution/**"
 iota-execution-cut:

.github/workflows/_cargo_deny.yml

@@ -2,6 +2,11 @@ name: Cargo deny
 
 on:
   workflow_call:
+    inputs:
+      manifest-path:
+        type: string
+        required: false
+        default: "./Cargo.toml"
     secrets:
       SSH_PRIVATE_KEY_IOTA_CI:
         required: true
@@ -13,24 +18,13 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  rust-crates:
-    name: cargo-deny (advisories, licenses, bans, ...)
-    runs-on: [self-hosted]
-    steps:
-      - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # pin@v4
-      - uses: EmbarkStudios/cargo-deny-action@8371184bd11e21dcf8ac82ebf8c9c9f74ebf7268 # pin@v2
-        with:
-          ssh-key: ${{ secrets.SSH_PRIVATE_KEY_IOTA_CI }}
-          ssh-known-hosts: ${{ secrets.SSH_GITHUB_KNOWN_HOSTS }}
-          use-git-cli: true
-
-  external-crates:
-    name: cargo-deny (advisories, licenses, bans, ...)
+  cargo-deny:
     runs-on: [self-hosted]
     steps:
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # pin@v4
       - uses: EmbarkStudios/cargo-deny-action@8371184bd11e21dcf8ac82ebf8c9c9f74ebf7268 # pin@v2
         with:
+          manifest-path: ${{ inputs.manifest-path }}
           ssh-key: ${{ secrets.SSH_PRIVATE_KEY_IOTA_CI }}
           ssh-known-hosts: ${{ secrets.SSH_GITHUB_KNOWN_HOSTS }}
           use-git-cli: true

.github/workflows/_e2e.yml

@@ -88,6 +88,14 @@ jobs:
           path: apps/explorer/playwright-report/
           retention-days: 30
 
+      - name: Build Kiosk
+        if: inputs.isRust || inputs.isTypescriptSDK
+        run: pnpm turbo --filter=@iota/kiosk build
+
+      - name: Run Kiosk e2e tests
+        if: inputs.isRust || inputs.isTypescriptSDK
+        run: pnpm dlx concurrently --kill-others --success command-1 "$E2E_RUN_LOCAL_NET_CMD" 'pnpm --filter=@iota/kiosk test:e2e'
+
       - name: Run Local net
         run: cargo run --bin iota start --force-regenesis --with-faucet --epoch-duration-ms 10000 &
 

.github/workflows/_ledgernano.yml

@@ -0,0 +1,45 @@
+name: Ledgernano End-to-end Tests
+
+on: workflow_call
+
+concurrency:
+  group: ledgernano-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  ledgernano:
+    name: Ledgernano
+    runs-on: self-hosted
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # Pin v4.1.1
+      - uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # [email protected]
+
+      - name: Install Nodejs
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # [email protected]
+        with:
+          node-version: "20"
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Install ledgernano dependencies
+        run: |
+          sudo apt-get install -y qemu-user-static
+          sudo apt-get install -y libxcb-xinerama0
+          sudo pip install speculos --break-system-packages
+
+      - name: Download ledgernano bin
+        run: |
+          sudo apt-get install -y gh
+          echo ${{ secrets.LEDGER_APP_TOKEN }} | gh auth login --with-token
+          gh release list --repo https://github.com/iotaledger/ledger-app-iota
+          gh release download --repo https://github.com/iotaledger/ledger-app-iota -p nanos.tar.gz untagged-a706a550379839d8db15
+          tar -xvf nanos.tar.gz
+          mv nanos/iota sdk/ledgerjs-hw-app-iota/tests/iota
+
+      - name: Start speculos simulator
+        run: speculos --api-port 5000 --display headless ./sdk/ledgerjs-hw-app-iota/tests/iota &
+
+      - name: Run TS SDK ledgernano tests
+        run: pnpm --filter @iota/ledgerjs-hw-app-iota test

.github/workflows/_rust.yml

@@ -62,6 +62,5 @@ jobs:
     if: |
       !cancelled() && !failure() && inputs.isRust && github.event.pull_request.draft == false
     needs:
-      - rust-tests
-      - external-tests
+      - rust-lints
     uses: ./.github/workflows/_execution_cut.yml

.github/workflows/_rust_lints.yml

@@ -51,10 +51,6 @@ jobs:
       - rustfmt
     runs-on: [self-hosted]
     steps:
-      - uses: arduino/setup-protoc@c65c819552d16ad3c9b72d9dfd5ba5237b9c906b # pin@v3
-        # this avoids rate-limiting
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # pin@v4
       # TODO(bradh): debug and re-enable this; the caching is breaking the clippy build
       # Enable caching of the 'librocksdb-sys' crate by additionally caching the

.github/workflows/_rust_tests.yml

@@ -72,8 +72,7 @@ jobs:
 
   check-unused-deps:
     name: Check Unused Dependencies (${{ matrix.flags }})
-    # Temporarily disabled until the nightly build bug is resolved
-    if: (!cancelled() && false)
+    if: (!cancelled())
     strategy:
       matrix:
         flags: ["--all-features", "--no-default-features"]

.github/workflows/_turborepo.yml

@@ -52,12 +52,6 @@ jobs:
       - name: (debug-before) Check SDK dist folder
         continue-on-error: true
         run: tree ./sdk/typescript/dist
-      - name: (debug) Lint
-        continue-on-error: true
-        run: pnpm turbo lint
-      - name: (debug-after) Check SDK dist folder
-        continue-on-error: true
-        run: tree ./sdk/typescript/dist
       - name: Lint
         run: pnpm turbo lint
       - name: Install wasm-pack for mbf package
@@ -73,7 +67,8 @@ jobs:
       - name: Build
         run: pnpm turbo build
       - name: Test
-        run: pnpm turbo test
+        # @iota/ledgerjs-hw-app-iota is tested separately
+        run: pnpm turbo test --filter '!@iota/ledgerjs-hw-app-iota'
       # Pack wallet extension and upload it as an artifact for easy developer use:
       - name: Wallet Extension Has Changes?
         id: wallet-diff

.github/workflows/_vercel_deploy.yml

@@ -21,72 +21,78 @@ on:
       shouldDeployPreview:
         type: boolean
         required: true
+      isDevelop:
+        type: boolean
+        required: true
+      githubRef:
+        type: string
+        required: true
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  group: ${{ github.workflow }}-${{ inputs.githubRef }}
   cancel-in-progress: true
 
 jobs:
   explorer-preview:
     name: Vercel Explorer Preview
     if: inputs.shouldDeployPreview && inputs.isExplorer
-    uses: ./.github/workflows/apps-explorer.deploy.yml
+    uses: ./.github/workflows/apps_explorer_deploy.yml
     secrets: inherit
     with:
       isProd: false
 
   explorer-prod:
     name: Vercel Explorer Production
-    if: github.ref_name == 'develop' && inputs.isExplorer
-    uses: ./.github/workflows/apps-explorer.deploy.yml
+    if: inputs.isDevelop
+    uses: ./.github/workflows/apps_explorer_deploy.yml
     secrets: inherit
     with:
       isProd: true
 
   ui-kit-preview:
     name: Vercel UI Kit Preview
     if: inputs.shouldDeployPreview && inputs.isAppsUiKit
-    uses: ./.github/workflows/apps-ui-kit.deploy.yml
+    uses: ./.github/workflows/apps_ui_kit_deploy.yml
     secrets: inherit
     with:
       isProd: false
 
   ui-kit-prod:
-    name: Vercel UI Kit Preview
-    if: github.ref_name == 'develop' && inputs.isAppsUiKit
-    uses: ./.github/workflows/apps-ui-kit.deploy.yml
+    name: Vercel UI Kit Production
+    if: inputs.isDevelop
+    uses: ./.github/workflows/apps_ui_kit_deploy.yml
     secrets: inherit
     with:
       isProd: true
 
   wallet-dashboard-preview:
     name: Vercel Wallet Dashboard Preview
     if: inputs.shouldDeployPreview && inputs.isWalletDashboard
-    uses: ./.github/workflows/apps-wallet-dashboard.deploy.yml
+    uses: ./.github/workflows/apps_wallet_dashboard_deploy.yml
     secrets: inherit
     with:
       isProd: false
 
   wallet-dashboard-prod:
     name: Vercel Wallet Dashboard Production
-    if: github.ref_name == 'develop' && inputs.isWalletDashboard
-    uses: ./.github/workflows/apps-wallet-dashboard.deploy.yml
+    if: inputs.isDevelop
+    uses: ./.github/workflows/apps_wallet_dashboard_deploy.yml
     secrets: inherit
     with:
       isProd: true
 
   apps-backend-preview:
     name: Vercel apps-backend Preview
     if: inputs.shouldDeployPreview && inputs.isAppsBackend
-    uses: ./.github/workflows/apps-backend.deploy.yml
+    uses: ./.github/workflows/apps_backend_deploy.yml
     secrets: inherit
     with:
       isProd: false
 
   apps-backend-prod:
     name: Vercel apps-backend Production
-    if: github.ref_name == 'develop' && inputs.isAppsBackend
-    uses: ./.github/workflows/apps-backend.deploy.yml
+    if: inputs.isDevelop
+    uses: ./.github/workflows/apps_backend_deploy.yml
     secrets: inherit
     with:
       isProd: true