Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task (SC-Platform)]: Remove copied code in iota-node #1446

Closed
DaughterOfMars opened this issue Jul 25, 2024 · 3 comments
Closed

[Task (SC-Platform)]: Remove copied code in iota-node #1446

DaughterOfMars opened this issue Jul 25, 2024 · 3 comments

Comments

@DaughterOfMars
Copy link
Contributor 

          I saw that reqwest has been updated, does it change anything here? Could we remove?

Originally posted by @thibault-martinez in #1106 (comment)

Description

There is copied code in this crate from fastcrypto which may be removed eventually, if they update their reqwest dependency.
@DaughterOfMars DaughterOfMars mentioned this issue Jul 25, 2024
Merged
@thibault-martinez
Copy link
Member

Note that there is 2 instances of this copied code.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 24, 2024
@DaughterOfMars
Copy link
Contributor Author

This code no longer exists after the rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thibault-martinez @DaughterOfMars