fix(CI): Fix cargo deny #1106
Merged
fix(CI): Fix cargo deny #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dev-tools/fix-deny
DaughterOfMars
force-pushed
the
dev-tools/fix-deny
branch
from
67b7356 to
c878480
Compare
thibault-martinez
approved these changes
Jul 25, 2024
Dr-Electron
approved these changes
Jul 25, 2024
| services: | ||
| postgres: | ||
| image: postgres | ||
| env: | ||
| POSTGRES_PASSWORD: postgrespw |
There was a problem hiding this comment.
Just for me to maybe learn something. Why is this needed if the password is already set as job env?
There was a problem hiding this comment.
I'm going to go ahead and merge this, please remember to ask Chloé on Monday (she's off today)
miker83z
approved these changes
Jul 26, 2024
5 tasks
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(dependencies): Update jsonrpsee and related dependencies * replace todos * update dependencies * dprint * feature * update baselines and license * Switch from ethers to alloy * merge * Fix mock provider and a bug in the ws impl * update arrow/parquet * fix tokio dependency msim compatability * install crypto provider and other misc * update pcg crate usage and use vendored openssl * test fixes * more fixes and clippy * baselines and more clippy * disable mysticeti simtests too * fix test and fmt * roll back gcp-bigquery-client version * fix bug in mock provider and cleanup * remove outdated doc comment * replace B256 with TxHash * simplify * comment * remove merge problem * fix graphql-rpc job * Add prost to git allow * clippy * update dependencies * revert commented line * fix borked merge * move rustfmt skip * Reviews * Add comment explaining TlsAcceptor * remove axum macros feature usage * review and update dependencies * remove yaml_rust RUSTSEC ignore * reviews * cleanup helper functions * move import --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(dependencies): Update jsonrpsee and related dependencies * replace todos * update dependencies * dprint * feature * update baselines and license * Switch from ethers to alloy * merge * Fix mock provider and a bug in the ws impl * update arrow/parquet * fix tokio dependency msim compatability * install crypto provider and other misc * update pcg crate usage and use vendored openssl * test fixes * more fixes and clippy * baselines and more clippy * disable mysticeti simtests too * fix test and fmt * roll back gcp-bigquery-client version * fix bug in mock provider and cleanup * remove outdated doc comment * replace B256 with TxHash * simplify * comment * remove merge problem * fix graphql-rpc job * Add prost to git allow * clippy * update dependencies * revert commented line * fix borked merge * move rustfmt skip * Reviews * Add comment explaining TlsAcceptor * remove axum macros feature usage * review and update dependencies * remove yaml_rust RUSTSEC ignore * reviews * cleanup helper functions * move import --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
* chore(dependencies): Update jsonrpsee and related dependencies * replace todos * update dependencies * dprint * feature * update baselines and license * Switch from ethers to alloy * merge * Fix mock provider and a bug in the ws impl * update arrow/parquet * fix tokio dependency msim compatability * install crypto provider and other misc * update pcg crate usage and use vendored openssl * test fixes * more fixes and clippy * baselines and more clippy * disable mysticeti simtests too * fix test and fmt * roll back gcp-bigquery-client version * fix bug in mock provider and cleanup * remove outdated doc comment * replace B256 with TxHash * simplify * comment * remove merge problem * fix graphql-rpc job * Add prost to git allow * clippy * update dependencies * revert commented line * fix borked merge * move rustfmt skip * Reviews * Add comment explaining TlsAcceptor * remove axum macros feature usage * review and update dependencies * remove yaml_rust RUSTSEC ignore * reviews * cleanup helper functions * move import --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR fixes the errors in the cargo deny CI by updating various out of date dependencies with audit issues.
Weirdness
Some changes were made because dependencies are out-of-date, non-update-able, and have out-of-date sub-dependencies that cause build errors for us due to mismatching versions.
For instance, in crates/iota-node/src/lib.rs I have had to copy the functionality from the
fastcryptocrate because that library uses an older version ofreqwest, and the public API accepts areqwest::Client. If we tried to use the providedfetch_jwksfunction then we would have a compilation error due to the different versions of that type.Similarly for crates/iota-tls/src/acceptor.rs, the functionality of the
RustlsAcceptorfromaxum_serverwas copied to avoid version conflicts withrustls.These could be resolved in some cases by forking the dependency and updating the sub-dependencies.
Links to any relevant issues
Fixes #805