Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix output of iota validator make-validator-info #4437

Open
alexsporn opened this issue Dec 11, 2024 · 2 comments · May be fixed by #4571
Open

Fix output of iota validator make-validator-info #4437

alexsporn opened this issue Dec 11, 2024 · 2 comments · May be fixed by #4571
Assignees
@gokhan-simsek-iota
Labels
node Issues related to the Core Node team
Milestone
Post-Testnet Laun...

Comments

@alexsporn
Copy link
Member

When running iota validator make-validator-info the generated validator.info contains these lines:

...
  network-address: /dns/65.109.144.22/tcp/8080/http
  p2p-address: /dns/65.109.144.22/udp/8084
  primary-address: /dns/65.109.144.22/udp/8081
...

There are multiple issues that should be fixed:

  1. The primary-address should use .../tcp/8081
  2. If the passed <HOST_NAME> argument is an IPv4, we should use /ip4/65.109.144.22/... instead

None of these issues really cause stuff not to work, but it would reduce confusion when setting up a validator.
@alexsporn alexsporn added the node Issues related to the Core Node team label Dec 11, 2024
@gokhan-simsek-iota gokhan-simsek-iota self-assigned this Dec 11, 2024
@gokhan-simsek-iota
Copy link
Contributor

Started with primary-address, I see that Sui says /tcp/8081 in their doc.
https://docs.sui.io/guides/operator/validator-tasks#connectivity , but in their code it is still udp/8081 everywhere, except in narwhal/config/tests.

I had the impression that this is just a small change, looks like it is:

iota/crates/iota/src/validator_commands.rs

Lines 347 to 348 in cf7ec2b

primary_address: Multiaddr::try_from(format!(
"/dns/{}/udp/8081",

but I see that to be consistent we need to change many other parts of the code from udp to tcp:

search "/udp/8081"
9 results - 3 files

docker/iota-network/genesis/compose-validators.yaml:
  19      name: validator1
  20:     primary_address: /dns/validator1/udp/8081

  28      name: validator2
  29:     primary_address: /dns/validator2/udp/8081
...

docker/iota-private-network/configs/genesis-template.yaml:
...

docs/content/references/cli/validator.mdx:
  181    "p2pAddress": "/dns/validator-2.r.iota-rebased-testnet.iota.cafe/udp/8084",
  182:   "primaryAddress": "/dns/validator-2.r.iota-rebased-testnet.iota.cafe/udp/8081",
  183    "nextEpochAuthorityPubkeyBytes": null,

search "primary_address"
118 results - 25 files

e.g.
crates/iota/src/generate_genesis_checkpoint.rs:
  38:             primary_address: local_ip_utils::new_local_udp_address_for_testing(),

@alexsporn
Copy link
Member Author

@gokhan-simsek-iota yes, you can go ahead and update all references to 8081/udp to be 8081/tcp. Those are still from the Narwhal consensus.

@gokhan-simsek-iota gokhan-simsek-iota linked a pull request Dec 19, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gokhan-simsek-iota gokhan-simsek-iota

Labels
node Issues related to the Core Node team
Projects
None yet
Milestone
Post-Testnet Launch v0.8.x-rc
Development

Successfully merging a pull request may close this issue.

[DRAFT] fix(node): Fix output of iota validator make-validator-info iotaledger/iota
2 participants
@alexsporn @gokhan-simsek-iota