Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] fix(node): Fix output of iota validator make-validator-info #4571

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

[DRAFT] fix(node): Fix output of iota validator make-validator-info #4571

wants to merge 9 commits into from

Conversation

gokhan-simsek-iota
Copy link
Contributor

@gokhan-simsek-iota gokhan-simsek-iota commented Dec 19, 2024 •
edited
Loading

⚠️DRAFT⚠️

.
.

Description of change

Changing primary_address to use tcp instead of udp and adding ip4/ip6/dns support for the output file validator.info of iota validator make-validator-info cmd. More info also here: #4437

Links to any relevant issues

Fixes: #4437 Fix output of iota validator make-validator-info

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Check validator.info after each time running the cmds below, make sure primary_address uses tcp instead of udp and all addresses use this multiaddr format ip4/ip6/dns correctly depending on the address input of the cmd.

// dns
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org localhost 1000

// ip4
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org 127.0.0.1 1000

// ip6
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org 1000:0ac3:22a2:0000:0000:4b3c:0504:1234 1000

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • (they were already failing without my changes) I have checked that new and existing unit tests pass locally with my changes

@gokhan-simsek-iota gokhan-simsek-iota requested a review from a team as a code owner December 19, 2024 14:02
@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Dec 19, 2024
@DaughterOfMars
Copy link
Contributor

I pushed some minor improvements!

@gokhan-simsek-iota
Copy link
Contributor Author

@DaughterOfMars
Thanks, I have actually more commits, I just wanted to test the CI.
Does CI work if I choose DRAFT ?

@gokhan-simsek-iota gokhan-simsek-iota changed the title fix(node): Fix output of iota validator make-validator-info [DRAFT] fix(node): Fix output of iota validator make-validator-info Dec 19, 2024
@DaughterOfMars
Copy link
Contributor

@DaughterOfMars Thanks, I have actually more commits, I just wanted to test the CI. Does CI work if I choose DRAFT ?

Some of it will still run, but big things won't. If you want to keep running all the CI, marking this as a draft in the title is fine.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@gokhan-simsek-iota
Copy link
Contributor Author

Fyi. Will try to solve the failing checks and open a new PR with signed commits.

@DaughterOfMars
Copy link
Contributor

DaughterOfMars commented Dec 20, 2024 •
edited
Loading

Fyi. Will try to solve the failing checks and open a new PR with signed commits.

You can sign the commits all at once with this command, and force push them, if you'd prefer!

git rebase --exec "git commit --amend --no-edit -n -S" -i develop

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@gokhan-simsek-iota gokhan-simsek-iota force-pushed the core-node/fix-make-validator-info branch from 5f64749 to a9f6f82 Compare December 27, 2024 14:05
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodemartin kodemartin Awaiting requested review from kodemartin kodemartin is a code owner

@miker83z miker83z Awaiting requested review from miker83z miker83z is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
core-protocol documentation Improvements or additions to documentation node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix output of iota validator make-validator-info
3 participants
@gokhan-simsek-iota @DaughterOfMars @iota-ci