feat(wallet): rebrand hidden assets #2012
Conversation
|
This pull request has been deployed to Vercel. Latest commit: aa2eead ✅ Preview: https://apps-ui-gn32w03qx-iota1.vercel.app |
| const handleActionCardActionClick = (event: React.MouseEvent) => { | ||
| event?.stopPropagation(); | ||
| onClick?.(); | ||
| }; |
There was a problem hiding this comment.
| const handleActionCardActionClick = (event: React.MouseEvent) => { | |
| event?.stopPropagation(); | |
| onClick?.(); | |
| }; | |
| function handleActionClick (event: React.MouseEvent) { | |
| event?.stopPropagation(); | |
| onClick?.(); | |
| }; |
-
I know that in another file we are using an arrow function, but I’ve noticed that in many other places we use function declarations. It might be better to use the same approach for consistency.
-
I think
CardActionwe can remove from name, as it's inside CardAction component by default. I'd suggest to usehandleActionClick
| onClick={() => { | ||
| navigate( | ||
| isKioskOwnerToken(kioskClient.network, item.data) | ||
| ? `/kiosk?${new URLSearchParams({ | ||
| kioskId: getKioskIdFromOwnerCap(item.data!), | ||
| })}` | ||
| : `/nft-details?${new URLSearchParams({ | ||
| objectId, | ||
| }).toString()}`, | ||
| ); | ||
| ampli.clickedCollectibleCard({ | ||
| objectId, | ||
| collectibleType: type!, | ||
| }); | ||
| }} |
There was a problem hiding this comment.
Please, move it to separate function
|
This pull request has been deployed to Vercel. Latest commit: eac77e4 ✅ Preview: https://apps-ui-6hnrj2f1c-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: d377fea ✅ Preview: https://apps-ui-oo2q3vkjb-iota1.vercel.app |
apps/wallet/src/ui/app/shared/page-main-layout/PageMainLayout.tsx
|
This pull request has been deployed to Vercel. Latest commit: 5e3968a ✅ Preview: https://apps-ui-79z4bjrg4-iota1.vercel.app |
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
NESTED PR⚠️ merge first #1989
fixes #1796
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.