Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(iota): remove KeyToolCommand::{LoadKeypair, Unpack} #3223

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Oct 11, 2024

Description of change

Remove the unused and rather useless LoadKeypair and Unpack commands.
One can use iota keytool convert and iota keytool show to get the same information and to create a file/read from it one can use standard shell commands like these:

echo iotaprivkey1qqjgggrq47cgdp2x6wnuy6m5qud66pj9l3m0yt8vj23vs99c73xzcp5t0dd > priv.key
iota keytool convert "$(< priv.key)"

Links to any relevant issues

Fixes #3214

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporary block

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Thoralf-M Thoralf-M force-pushed the dev-tools/remove-keytool-loadKeypair branch from c2f7f1a to 854cf75 Compare October 17, 2024 07:51
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn alexsporn added the dev-tools Issues related to the Developer Tools Team label Oct 23, 2024
@Thoralf-M Thoralf-M force-pushed the dev-tools/remove-keytool-loadKeypair branch from 854cf75 to 35085a1 Compare October 24, 2024 18:18
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@thibault-martinez
Copy link
Member

Will have a look at this today, sorry for the delay.

@Thoralf-M Thoralf-M changed the title feat!(iota): remove KeyToolCommand::LoadKeypair feat!(iota): remove KeyToolCommand::{LoadKeypair, Unpack} Oct 29, 2024
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@thibault-martinez thibault-martinez merged commit f5b64c5 into develop Oct 29, 2024
36 of 40 checks passed
@thibault-martinez thibault-martinez deleted the dev-tools/remove-keytool-loadKeypair branch October 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(iota): remove KeyToolCommand::LoadKeypair command
5 participants