fix(iota-graphql-e2e-tests): restore remaining tests

[kodemartin]

Description of change

This patch updates the baselines and some source files for the remaining tests following #3333

Source files have been updated to account for different object indexing or digest generation due to our version of the framework.

Baselines are updated through UB=1 cargo nextest .... The updated baselines are consistent with the expectations of the test tasks.

Links to any relevant issues

Fixes #2140
Fixes #2614

Type of change

• Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Requires running postgres server. See instructions

$ cargo nextest run -p iota-graphql-e2e-tests --features pg_integration

Change checklist

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked that new and existing unit tests pass locally with my changes

[sergiupopescu199]

lgtm ✨

[valeriyr]

Is it ok that several objects were added?

[kodemartin]

These seem to be validator rewards at end of epochs

Response: {                                                                                                                   
  "data": {                                                                                                                   
    "object": {                                                                                                               
      "address": "0x21f295b9bb94db811614a123b74f91c30dab67ec6e6a8d2ebd7b66ddcca1d7a5",                                        
      "digest": "B2NRsY8irYUJAg86na1LDvizcH5nXgjxnXcVWXkxfcqV",                                                               
      "owner": {                                                                                                              
        "__typename": "AddressOwner"                           
      },                                                       
      "version": 5,  
      "previousTransactionBlock": {                                                                                           
        "kind": {                                                                                                             
          "__typename": "EndOfEpochTransaction"                                                                               
        }                                                                                                                     
      },                                                                                                                      
      "asMoveObject": {                                                                                                       
        "contents": {                                                                                                         
          "type": {                                                                                                           
            "repr": "0x0000000000000000000000000000000000000000000000000000000000000003::staking_pool::StakedIota"             
          }                                                                                                                   
        }                                                                                                                     
      }                                                                                                                       
    }                                                                                                                         
  }                                                                                                                           
}                                                                                                                             
                                                                                                                              
task 31, lines 126-148:                                                                                                       
//# run-graphql         
Response: {                                                                                                                   
  "data": {                                                                                                                   
    "object": {                                                                                                               
      "address": "0x34cf8d6d02620ba9aaf03759cfcaa6b6cd21d6171fc27ab43b22411bc4d328e4",                                        
      "digest": "5gEgTUgEgeAfP7kkY7K9fbhD6qLu6yyasRrxopqZU3wa",                                                               
      "owner": {                                                                                                              
        "__typename": "AddressOwner"                                                                                          
      },                                                                                                                      
      "version": 6,                                                                                                           
      "previousTransactionBlock": {                            
        "kind": {    
          "__typename": "EndOfEpochTransaction"                                                                               
        }                                                                                                                     
      },                                                                                                                      
      "asMoveObject": {                                                                                                       
        "contents": {                                                                                                         
          "type": {                                                                                                           
            "repr": "0x0000000000000000000000000000000000000000000000000000000000000003::staking_pool::StakedIota"            
          }                                                                                                                   
        }                                                                                                                     
      }                                                                                                                       
    }                                                                                                                         
  }                                                                                                                           
}   

We advance 6 epochs, equal to the number of added objects, so this is expected.

[valeriyr]

Looks like this event just disappeared?

[kodemartin]

Good catch! There are some fixed digests in the queries, that required update. I had fixed all cases in event_connection/tx_digest but missed that. Thank you!

Fixed with 8885083

[valeriyr]

Is this field should be empty?

[kodemartin]

These are the genesis Display events. Added more context in the query with 1c6eb83

[valeriyr]

Looks like this test is broken. It should return the objects like this:

Selects the first two objects
Selects the 2nd and 3rd objects
Selects 4th and the last object
Selects 3rd and 4th object
Selects the two last objects

It is an example of a nondeterministic test that needs to be corrected after the framework update.
It acts wrong if just update the .exp file, you need to fix the related .move one.
It is the reason why such tests should be fixed or documented, or it will test a wrong scenario.

More details here:
#1969 (comment)

[valeriyr]

hm, looks like this test was changed since the last time I saw it. Probably just need to check if it is ok :)

[kodemartin]

I updated the comments and added more info through queries with fef4fb0

The order of the created objects in the server is based on their addresses, and hence by their object ids. When we call after: @{cursor_0} where cursor: @{object_x_y} we request objects with address larger than the address of object_x_y. When we call before we ask for objects with smaller address.

For a given version of the framework the generated object ids remain the same between consecutive runs. If something breaks the object-id generation then normally this would warrant a protocol upgrade and we would still be fine with this test as we call init with a fixed protocol config version.

But until we stabilize genesis and the framework for protocol 1, it will suffice to do the chore of updating the comments.

That is, if we want to document the query scenarios. Otherwise we can omit the comments, and rely on the correctness of the graphql server, which at this stage seems like a reasonable premise.

[valeriyr]

For a given version of the framework the generated object ids remain the same between consecutive runs. If something breaks the object-id generation then normally this would warrant a protocol upgrade and we would still be fine with this test as we call init with a fixed protocol config version.

Yes, it is deterministic for the same protocol version but not between them. It was necessary to check every time that a test checks what was expected.

I see that the Sui team stopped updating the protocol version in their graphql tests since the version 51 what they did before. So in this case it will not be a problem. But is is ok to check the server with an outdated version?

[kodemartin]

I would expect tests to be stable for outdated versions unless we introduce breaking changes on account of a protocol upgrade.

In upstream they have classified the tests as stable and staging now, likely to be explicit about the expectations for each category of tests.

We'll have to revisit this as our protocol progresses.