feat(docs): Add abilities from the Move book #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Signed-off-by: salaheldinsoliman <[email protected]>
salaheldinsoliman
force-pushed
the
devx/add-MoveBook-to-docs
branch
from
d078e0f to
67c08d6
Compare
salaheldinsoliman
changed the title
|
✅ Vercel Preview Deployment is ready! |
lucas-tortora
requested changes
Oct 25, 2024
docs/content/developer/iota-101/move-overview/structs-and-abilities/struct.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/struct.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/copy.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/copy.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/store.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/store.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/store.mdx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,84 @@ | |||
| # Visibility Modifiers | |||
There was a problem hiding this comment.
This article overlaps with https://docs.iota.org/developer/iota-101/move-overview/entry-functions. WDYT about merging them?
There was a problem hiding this comment.
The one added gives an overview of visibility modifiers, while https://docs.iota.org/developer/iota-101/move-overview/entry-functions explains when and why to use entry, public and public entry
I think we should keep them separate, while mentioning entry-functions.mdx in the newly added overview
Does that make sense?
Co-authored-by: Lucas Tortora <[email protected]>
|
✅ Vercel Preview Deployment is ready! |
Signed-off-by: salaheldinsoliman <[email protected]>
|
✅ Vercel Preview Deployment is ready! |
salaheldinsoliman
requested review from
Ginowine,
Dr-Electron and
lucas-tortora
lucas-tortora
requested changes
Oct 29, 2024
docs/content/developer/iota-101/move-overview/structs-and-abilities/copy.mdx
Outdated
Show resolved
Hide resolved
vivekjain23
requested changes
Nov 4, 2024
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Show resolved
Hide resolved
Signed-off-by: salaheldinsoliman <[email protected]>
Co-authored-by: vivekjain23 <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
…dger/iota into devx/add-MoveBook-to-docs
Signed-off-by: salaheldinsoliman <[email protected]>
vivekjain23
reviewed
Nov 5, 2024
lucas-tortora
requested changes
Nov 7, 2024
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Outdated
Show resolved
Hide resolved
docs/content/developer/iota-101/move-overview/structs-and-abilities/abilities-intro.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Tortora <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
lucas-tortora
approved these changes
Nov 11, 2024
Ginowine
approved these changes
Nov 12, 2024
|
✅ Vercel Preview Deployment is ready! |
vivekjain23
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add docs about structs and abilities from the move book, and link it to our docs
Links to any relevant issues
Related to #3744
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Docs built locally
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.