Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-dashboard): wrong available for timelocked staking #3734

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Oct 29, 2024

Description of change

Fix wrong available for timelocked staking

Links to any relevant issues

Closes #2183

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@cpl121 cpl121 marked this pull request as ready for review October 29, 2024 09:49
@cpl121 cpl121 requested review from a team as code owners October 29, 2024 09:49
@cpl121 cpl121 added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Oct 29, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9d03b3a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-akeef327a.vercel.app

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fail, there is probably something wrong in the tests not considering the min staking amount

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: df00d97

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ngnozqbg6.vercel.app

@cpl121 cpl121 requested a review from begonaalvarezd October 29, 2024 10:39
@begonaalvarezd begonaalvarezd merged commit 1e17f6c into develop Oct 29, 2024
28 of 30 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-dashboard/fix-wrong-available-timelocked-staking branch October 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (tooling/wallet-dashboard)]: Fix wrong available for timelocked staking
3 participants