-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocol upgrade (v2): Burn slashed rewards (phase RD 1) + changes to system epoch info event #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsporn
added
the
tokenomics
Issues related to tokenomics and gas price modulation
label
Oct 29, 2024
muXxer
force-pushed
the
protocol/burn_slashed_rewards-RD1
branch
2 times, most recently
from
November 1, 2024 17:12
4b782b5
to
8f5002a
Compare
muXxer
reviewed
Nov 1, 2024
crates/iota-framework/packages/iota-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
crates/iota-framework/packages/iota-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
crates/iota-framework/packages/iota-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
muXxer
force-pushed
the
protocol/burn_slashed_rewards-RD1
branch
from
November 3, 2024 20:14
2474dba
to
a5d37b8
Compare
muXxer
force-pushed
the
protocol/burn_slashed_rewards-RD1
branch
from
November 5, 2024 13:12
a5d37b8
to
36478bc
Compare
oliviasaa
commented
Nov 5, 2024
crates/iota-framework/packages/iota-system/sources/validator_set.move
Outdated
Show resolved
Hide resolved
…et.move correction in a comment
show correct burnt amount in SystemEpochInfoEventV1
Thoralf-M
reviewed
Dec 9, 2024
miker83z
changed the title
Protocol/burn slashed rewards rd1
protocol upgrade (v2): Burn slashed rewards (phase RD 1) + changes to system epoch info event
Dec 10, 2024
valeriyr
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lzpap
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kodemartin
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thibault-martinez
approved these changes
Dec 11, 2024
Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Phase RD 1: In this phase, the grading and reporting of validators remain unchanged. Instead of adjusting rewards so that slashed rewards are assigned to non-slashed validators, we remove this adjustment, entirely burning the slashed rewards, which would go to the protocol instead of going to the non-slashed validator set.
SystemEpochInfoEventV1
(emitted from the advance_epoch function)Links to any relevant issues
Fixes #3123
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
The reward amounts were tested and checked for both slashed and non-slashed validators
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.