Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol upgrade (v2): Burn slashed rewards (phase RD 1) + changes to system epoch info event #3739

Merged
merged 35 commits into from
Dec 11, 2024

Conversation

oliviasaa
Copy link
Contributor

@oliviasaa oliviasaa commented Oct 29, 2024

Description of change

  • Changes in the reward distribution so the slashed rewards from a validator are not redistributed to the others.
    Phase RD 1: In this phase, the grading and reporting of validators remain unchanged. Instead of adjusting rewards so that slashed rewards are assigned to non-slashed validators, we remove this adjustment, entirely burning the slashed rewards, which would go to the protocol instead of going to the non-slashed validator set.
  • Change the information about burned tokens amount in the SystemEpochInfoEventV1 (emitted from the advance_epoch function)

Links to any relevant issues

Fixes #3123

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

The reward amounts were tested and checked for both slashed and non-slashed validators

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@oliviasaa oliviasaa requested review from a team as code owners October 29, 2024 10:20
@alexsporn alexsporn added the tokenomics Issues related to tokenomics and gas price modulation label Oct 29, 2024
@muXxer muXxer requested a review from a team as a code owner November 1, 2024 16:13
@muXxer muXxer force-pushed the protocol/burn_slashed_rewards-RD1 branch 2 times, most recently from 4b782b5 to 8f5002a Compare November 1, 2024 17:12
@muXxer muXxer force-pushed the protocol/burn_slashed_rewards-RD1 branch from 2474dba to a5d37b8 Compare November 3, 2024 20:14
@muXxer muXxer force-pushed the protocol/burn_slashed_rewards-RD1 branch from a5d37b8 to 36478bc Compare November 5, 2024 13:12
@oliviasaa oliviasaa requested a review from muXxer November 5, 2024 13:29
@cyberphysic4l cyberphysic4l requested a review from a team as a code owner December 4, 2024 11:54
@cyberphysic4l cyberphysic4l marked this pull request as draft December 4, 2024 11:54
@cyberphysic4l cyberphysic4l marked this pull request as ready for review December 5, 2024 11:38
@cyberphysic4l cyberphysic4l requested a review from a team as a code owner December 5, 2024 20:11
@miker83z miker83z changed the title Protocol/burn slashed rewards rd1 protocol upgrade (v2): Burn slashed rewards (phase RD 1) + changes to system epoch info event Dec 10, 2024
Copy link
Contributor

@valeriyr valeriyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lzpap lzpap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/iota-protocol-config/src/lib.rs Outdated Show resolved Hide resolved
crates/iota-protocol-config/src/lib.rs Show resolved Hide resolved
@lzpap lzpap merged commit b7e7a60 into develop Dec 11, 2024
40 of 42 checks passed
@lzpap lzpap deleted the protocol/burn_slashed_rewards-RD1 branch December 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol research tokenomics Issues related to tokenomics and gas price modulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gas-price-modulation-tf]: Burn slashed rewards