Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest-api): Move /rest and /v2 endpoints to /api/v1 #3740

Merged
merged 5 commits into from
Oct 29, 2024
Merged

fix(rest-api): Move /rest and /v2 endpoints to /api/v1 #3740

merged 5 commits into from
Oct 29, 2024

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Oct 29, 2024

Description of change

We moved all /rest or /v2 endpoints to /api/v1 to have a clean start.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners October 29, 2024 10:22
@muXxer muXxer added the node Issues related to the Core Node team label Oct 29, 2024
@muXxer muXxer added this to the Testnet milestone Oct 29, 2024
junwei0117
junwei0117 reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@junwei0117 junwei0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexsporn alexsporn mentioned this pull request Oct 29, 2024
Closed
20 tasks
@alexsporn alexsporn merged commit 0fa5f2a into develop Oct 29, 2024
31 of 39 checks passed
@alexsporn alexsporn deleted the core-node/fix/rest-api-version-1 branch October 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@junwei0117 junwei0117 junwei0117 approved these changes

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
node Issues related to the Core Node team
Projects
None yet
Milestone
Testnet Launch v0.7.x-rc
Development

Successfully merging this pull request may close these issues.
5 participants
@muXxer @alexsporn @junwei0117 @sergiupopescu199 @Thoralf-M