feat(wallet-dashboard): add grid for visual assets #3758

VmMad · 2024-10-29T13:15:29Z

Depends on #3724

…shboard/add-assets-layout

apps/wallet-dashboard/app/(protected)/assets/[objectId]/page.tsx apps/wallet-dashboard/app/(protected)/assets/everything-else/page.tsx apps/wallet-dashboard/app/(protected)/assets/visual-assets/[objectId]/page.tsx apps/wallet-dashboard/app/(protected)/assets/visual-assets/page.tsx apps/wallet-dashboard/app/(protected)/components/top-nav/TopNav.tsx apps/wallet-dashboard/app/dashboard/assets/visual-assets/[objectId]/page.tsx

github-actions · 2024-10-29T13:17:53Z

This pull request has been deployed to Vercel.

Latest commit: 551b48f

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d8wifj42c.vercel.app

github-actions · 2024-10-29T13:18:10Z

This pull request has been deployed to Vercel.

Latest commit: 551b48f

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9xgdclqqh.vercel.app

github-actions · 2024-10-29T13:18:34Z

This pull request has been deployed to Vercel.

Latest commit: 551b48f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-riht46i97.vercel.app

apps/wallet-dashboard/app/(protected)/assets/page.tsx

…oard/add-assets-styles

github-actions · 2024-11-04T09:23:52Z

This pull request has been deployed to Vercel.

Latest commit: a4db526

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-33amgcgqu.vercel.app

github-actions · 2024-11-04T09:24:10Z

This pull request has been deployed to Vercel.

Latest commit: a4db526

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-mdb8d913t.vercel.app

github-actions · 2024-11-04T09:25:00Z

This pull request has been deployed to Vercel.

Latest commit: a4db526

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ejjkluj06.vercel.app

marc2332

I forgot to actually put the review..

marc2332 · 2024-10-29T15:10:13Z

apps/wallet-dashboard/components/Cards/AssetCard.tsx


-interface AssetCardProps {
+type AssetCardProps = {


can't you just do something like ?

Suggested change

type AssetCardProps = {

interface AssetCardProps extends Pick<VisualAssetCardProps, 'onclick' | 'onIconClick' | 'icon'> {

marc2332 · 2024-10-29T15:10:31Z

apps/wallet-dashboard/components/Cards/AssetCard.tsx

    asset: IotaObjectData;
    flexDirection?: FlexDirection;
-}
+} & Pick<React.ComponentProps<typeof VisualAssetCard>, 'onClick' | 'onIconClick' | 'icon'>;


Suggested change

} & Pick<React.ComponentProps<typeof VisualAssetCard>, 'onClick' | 'onIconClick' | 'icon'>;

}

marc2332 · 2024-10-29T15:12:51Z

apps/wallet-dashboard/components/Cards/AssetCard.tsx

+        <>
+            {asset.display && nftMeta && nftMeta.imageUrl && (
+                <VisualAssetCard
+                    assetSrc={nftMeta?.imageUrl ?? asset?.display?.data?.imageUrl ?? ''}
+                    assetTitle={nftMeta?.name ?? asset?.display?.data?.name}
+                    assetType={VisualAssetType.Image}
+                    altText={nftMeta?.name ?? (asset?.display?.data?.name || 'NFT')}
+                    isHoverable
+                    icon={icon}
+                    onClick={onClick}
+                    onIconClick={onIconClick}
+                />
+            )}
+        </>


simpler, right?

Suggested change

<>

{asset.display && nftMeta && nftMeta.imageUrl && (

<VisualAssetCard

assetSrc={nftMeta?.imageUrl ?? asset?.display?.data?.imageUrl ?? ''}

assetTitle={nftMeta?.name ?? asset?.display?.data?.name}

assetType={VisualAssetType.Image}

altText={nftMeta?.name ?? (asset?.display?.data?.name || 'NFT')}

isHoverable

icon={icon}

onClick={onClick}

onIconClick={onIconClick}

/>

)}

</>

if(!asset.display || !nftMeta || !nftMeta.imageUrl){

return null

}

return (

<VisualAssetCard

assetSrc={nftMeta?.imageUrl ?? asset?.display?.data?.imageUrl ?? ''}

assetTitle={nftMeta?.name ?? asset?.display?.data?.name}

assetType={VisualAssetType.Image}

altText={nftMeta?.name ?? (asset?.display?.data?.name || 'NFT')}

isHoverable

icon={icon}

onClick={onClick}

onIconClick={onIconClick}

/>

)

marc2332 · 2024-10-29T15:15:18Z

apps/wallet-dashboard/components/PaginationOptions.tsx

+                        type={ButtonType.Secondary}
+                        size={ButtonSize.Small}
+                        {...button}
+                        key={index}


nit: simply put the key as the first prop, it behaves the same but its easier to read

Suggested change

type={ButtonType.Secondary}

size={ButtonSize.Small}

{...button}

key={index}

key={index}

type={ButtonType.Secondary}

size={ButtonSize.Small}

{...button}

github-actions · 2024-11-06T10:23:05Z

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

github-actions · 2024-11-06T10:23:38Z

This pull request has been deployed to Vercel.

Latest commit: 9c5032e

✅ Preview: https://apps-ui-7e4x6t8dz-iota1.vercel.app

github-actions · 2024-11-06T10:23:57Z

This pull request has been deployed to Vercel.

Latest commit: 9c5032e

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5ro8hwc9f.vercel.app

github-actions · 2024-11-06T10:24:26Z

This pull request has been deployed to Vercel.

Latest commit: 9c5032e

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-qoqdj521b.vercel.app

github-actions · 2024-11-06T10:24:36Z

This pull request has been deployed to Vercel.

Latest commit: 9c5032e

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-f5kzaqncl.vercel.app

VmMad and others added 14 commits October 25, 2024 18:04

feat(wallet-dashboard): add protected layout

b0c9983

feat: add missing TopNav

670f496

fix: tests

d43a921

Merge branch 'develop' into tooling-dashboard/add-connected-layout

5ba9405

fix: imports

1100c2c

Merge branch 'develop' into tooling-dashboard/add-connected-layout

0f30b19

feat(wallet-dashboard): add assets page

a74ff0e

Merge branch 'tooling-dashboard/add-connected-layout' into tooling-da…

9d4abe6

…shboard/add-assets-layout

fix: add missing themes

37ce97e

Merge branch 'tooling-dashboard/add-connected-layout' into tooling-da…

8a8f711

…shboard/add-assets-layout

feat: improve connect button size

6de4fc2

revert: "feat: improve connect button size"

bc4612b

feat(wallet-dashboard): add grid for visual assets

551b48f

VmMad requested review from a team as code owners October 29, 2024 13:15

VmMad added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Oct 29, 2024

VmMad linked an issue Oct 29, 2024 that may be closed by this pull request

Style visual assets #3692

Closed

VmMad mentioned this pull request Oct 29, 2024

feat(wallet-dashboard): add styles for non visual assets #3761

Merged

evavirseda requested changes Oct 29, 2024

View reviewed changes

apps/wallet-dashboard/app/(protected)/assets/page.tsx Show resolved Hide resolved

refactor: remove unnecessary useMemo

ea32c22

VmMad requested a review from evavirseda October 30, 2024 08:15

evavirseda approved these changes Oct 30, 2024

View reviewed changes

VmMad and others added 3 commits October 30, 2024 12:32

fix: remove commented lines

8b5348a

Merge branch 'develop' into tooling-dashboard/add-assets-layout

f6ddc10

Merge branch 'tooling-dashboard/add-assets-layout' into tooling-dashb…

a4db526

…oard/add-assets-styles

VmMad requested a review from msarcev November 5, 2024 11:00

Base automatically changed from tooling-dashboard/add-assets-layout to develop November 6, 2024 09:26

marc2332 requested changes Nov 6, 2024

View reviewed changes

VmMad added 3 commits November 6, 2024 10:56

fix: improve type

0753921

Merge branch 'develop' into tooling-dashboard/add-assets-styles

f0131a0

fix: update IotaLogo

9c5032e

VmMad requested a review from a team as a code owner November 6, 2024 10:21

VmMad requested a review from marc2332 November 6, 2024 10:24

cpl121 approved these changes Nov 6, 2024

View reviewed changes

marc2332 approved these changes Nov 7, 2024

View reviewed changes

marc2332 merged commit 0d967e5 into develop Nov 7, 2024
31 checks passed

marc2332 deleted the tooling-dashboard/add-assets-styles branch November 7, 2024 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet-dashboard): add grid for visual assets #3758

feat(wallet-dashboard): add grid for visual assets #3758

VmMad commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

marc2332 left a comment

marc2332 Oct 29, 2024

marc2332 Oct 29, 2024

marc2332 Oct 29, 2024

marc2332 Oct 29, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

	type AssetCardProps = {
	interface AssetCardProps extends Pick<VisualAssetCardProps, 'onclick' \| 'onIconClick' \| 'icon'> {

	} & Pick<React.ComponentProps<typeof VisualAssetCard>, 'onClick' \| 'onIconClick' \| 'icon'>;
	}

feat(wallet-dashboard): add grid for visual assets #3758

feat(wallet-dashboard): add grid for visual assets #3758

Conversation

VmMad commented Oct 29, 2024 • edited Loading

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

marc2332 left a comment

Choose a reason for hiding this comment

marc2332 Oct 29, 2024

Choose a reason for hiding this comment

marc2332 Oct 29, 2024

Choose a reason for hiding this comment

marc2332 Oct 29, 2024

Choose a reason for hiding this comment

marc2332 Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

VmMad commented Oct 29, 2024 •

edited

Loading