Refactor Indexer caching for exchange_rates and validators_apys to use instance-level caches, fixing cargo test failures
#3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to work with `cargo test`
|
This pull request has been deployed to Vercel. Latest commit: b0391df ✅ Preview: https://apps-ui-nxmwmyqym-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: b0391df ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-p1o9t1n8k.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: b0391df ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-2f5l99mlt.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: b0391df ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-rjoqmewu9.vercel.app |
tomxey
reviewed
Oct 30, 2024
tomxey
reviewed
Oct 30, 2024
tomxey
reviewed
Oct 30, 2024
samuel-rufi
merged commit 527fab1
into
sc-platform/indexer-new-rpc-tests
28 of 32 checks passed
sergiupopescu199
pushed a commit
that referenced
this pull request
Oct 31, 2024
… in order to work with `cargo test` (#3774)
sergiupopescu199
pushed a commit
that referenced
this pull request
Oct 31, 2024
… in order to work with `cargo test` (#3774)
sergiupopescu199
pushed a commit
that referenced
this pull request
Oct 31, 2024
… in order to work with `cargo test` (#3774)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR addresses an issue in
iota-indexerwhere global caches in theexchange_ratesandvalidators_apysfunctions cause test failures when runningcargo testwith dedicated clusters (ownTestClusterper test). By refactoring these functions to use instance-level caches, we prevent test interference and ensure that tests can run in parallel without conflicts.Links to any relevant issues
Fixes #3773
Type of change
How the change has been tested
cargo test --features shared_test_runtime -- --nocaptureChange checklist