Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Fix iota-storage::key_value_tests simtests::test_multi_fetch #3784

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

bingyanglin
Copy link
Contributor

Description of change

With @piotrm50 together to fix the iota-storage::key_value_tests simtests::test_multi_fetch by correcting the test_server and its get_data logic

Links to any relevant issues

Part of #3321

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Passed the testing by

 ./scripts/simtest/cargo-simtest simtest \
  --color always \
  --package iota-storage --test key_value_tests -- simtests::test_multi_fetch

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin requested a review from a team as a code owner October 30, 2024 10:59
@bingyanglin bingyanglin added the node Issues related to the Core Node team label Oct 30, 2024
@bingyanglin bingyanglin self-assigned this Oct 30, 2024
@bingyanglin bingyanglin merged commit 490775b into develop Oct 31, 2024
34 of 39 checks passed
@bingyanglin bingyanglin deleted the core-node/fix/test-multi-fetch branch October 31, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants