Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iota-types): Remove trait ParentSync #3799

Merged
merged 4 commits into from
Oct 31, 2024
Merged

refactor(iota-types): Remove trait ParentSync #3799

merged 4 commits into from
Oct 31, 2024

Conversation

jkrvivian
Copy link
Contributor

@jkrvivian jkrvivian commented Oct 30, 2024 •
edited
Loading

Description of change

Remove the ParentSync trait, which only contains a deprecated method get_latest_parent_entry_ref_deprecated, and eliminate all its implementations.

Links to any relevant issues

Part of #2092

Type of change

  • Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian added the node Issues related to the Core Node team label Oct 30, 2024
@jkrvivian jkrvivian self-assigned this Oct 30, 2024
@jkrvivian jkrvivian requested review from a team, miker83z and valeriyr as code owners October 30, 2024 14:08
@jkrvivian jkrvivian mentioned this pull request Oct 30, 2024
Closed
18 tasks
miker83z
miker83z requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is a leftover:

crates/iota-replay/src/replay.rs Show resolved Hide resolved
@muXxer muXxer requested a review from miker83z October 30, 2024 17:21
@bingyanglin bingyanglin merged commit acc9e45 into develop Oct 31, 2024
35 of 39 checks passed
@bingyanglin bingyanglin deleted the core-node/fix/remove-ParentSync branch October 31, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muXxer muXxer muXxer approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@miker83z miker83z miker83z approved these changes

@alexsporn alexsporn alexsporn approved these changes

@valeriyr valeriyr valeriyr approved these changes

Assignees

@jkrvivian jkrvivian

Labels
node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jkrvivian @valeriyr @alexsporn @miker83z @muXxer @Thoralf-M @bingyanglin