Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): fix missing dependencies for shallow_size_of #3806

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Oct 30, 2024

Description of change

This fixes the broken rust / rust-tests / Check Unused Dependencies (--no-default-features) test,

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners October 30, 2024 16:07
@bingyanglin bingyanglin merged commit 34a31c6 into develop Oct 31, 2024
34 of 39 checks passed
@bingyanglin bingyanglin deleted the core-node/fix/malloc-size-of-dependencies branch October 31, 2024 03:06
@muXxer muXxer added the node Issues related to the Core Node team label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants