Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iota-core): Remove deprecated AuthorityPerpetualTables/AuthorityStore related code #3829

Merged
merged 20 commits into from
Nov 5, 2024

Conversation

bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Oct 31, 2024

Description of change

Removed deprecated AuthorityPerpetualTables/AuthorityStore related code

Links to any relevant issues

Part of #2092

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Ran the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Oct 31, 2024
@bingyanglin bingyanglin self-assigned this Oct 31, 2024
@bingyanglin bingyanglin requested review from a team as code owners October 31, 2024 12:54
@bingyanglin bingyanglin mentioned this pull request Oct 31, 2024
18 tasks
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muXxer muXxer merged commit d891762 into develop Nov 5, 2024
40 of 41 checks passed
@muXxer muXxer deleted the core-node/fix/remove-deprecated-authority-code branch November 5, 2024 08:55
bingyanglin added a commit that referenced this pull request Nov 20, 2024
…les`/`AuthorityStore` related code (#3829)"

This reverts commit d891762.
semenov-vladyslav pushed a commit that referenced this pull request Nov 22, 2024
…les`/`AuthorityStore` related code (#3829)"

This reverts commit d891762.
bingyanglin added a commit that referenced this pull request Nov 26, 2024
…multi_get_transaction_checkpoint` (#4164)

* Revert "refactor(iota-core): Remove deprecated `AuthorityPerpetualTables`/`AuthorityStore` related code (#3829)"

This reverts commit d891762.

* fix(iota-core): cleanup/rename stuff still in use but marked as deprecated after previous revert

* Fmt

* Add get_transaction_checkpoint back

* feat(iota-json-rpc-tests): add get_transaction_block_timestamp test

Test by @kodemartin.

---------

Co-authored-by: Vlad Semenov <[email protected]>
Co-authored-by: Vlad Semenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants