Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iota-types): Use bcs for signature conversions #3830

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix(iota-types): Use bcs for signature conversions #3830

merged 3 commits into from
Oct 31, 2024

Conversation

DaughterOfMars
Copy link
Contributor

@DaughterOfMars DaughterOfMars commented Oct 31, 2024 •
edited
Loading

Description of change

Go back to using bcs to serialize/deserialize signatures between iota-rust-sdk and the internal types.

Related Issues

#3803

@DaughterOfMars DaughterOfMars requested review from a team as code owners October 31, 2024 13:00
@alexsporn alexsporn added the dev-tools Issues related to the Developer Tools Team label Oct 31, 2024
@alexsporn alexsporn mentioned this pull request Oct 31, 2024
Merged
@lzpap lzpap mentioned this pull request Oct 31, 2024
Closed
10 tasks
@alexsporn alexsporn merged commit c13a8c0 into develop Oct 31, 2024
35 of 39 checks passed
@alexsporn alexsporn deleted the dev-tools/sig-convert branch October 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miker83z miker83z miker83z approved these changes

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
dev-tools Issues related to the Developer Tools Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaughterOfMars @alexsporn @miker83z @lzpap