fix(iota-benchmark/tests): fix test_simulated_load_reconfig_restarts #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… access_clock_object_test
muXxer
approved these changes
Nov 1, 2024
valeriyr
requested changes
Nov 1, 2024
miker83z
reviewed
Nov 4, 2024
valeriyr
reviewed
Nov 5, 2024
miker83z
changed the title
…_simulated_load_reconfig_restarts,-access_clock_object_test)
miker83z
approved these changes
Nov 7, 2024
valeriyr
approved these changes
Nov 7, 2024
samuel-rufi
requested changes
Nov 7, 2024
| @@ -468,10 +468,9 @@ async fn call_shared_object_contract() { | |||
| ); | |||
| } | |||
|
|
|||
| #[ignore("Disabled due to flakiness - re-enable when failure is fixed")] | |||
There was a problem hiding this comment.
instead of this comment, can you put in a link to a tracking GH issue?
There was a problem hiding this comment.
Do you mean create new one? Because it's original Sui's comment and there is no appropriate issue for it as I see
There was a problem hiding this comment.
Yes you could create one issue in the Product Backlog with low priority
Thoralf-M
approved these changes
Nov 11, 2024
…d_reconfig_restarts,-access_clock_object_test)' of github.com:iotaledger/kinesis into sc-platfrom/fix-iota-benchmark-tests(test_simulated_load_reconfig_restarts,-access_clock_object_test)
samuel-rufi
approved these changes
Nov 12, 2024
…_simulated_load_reconfig_restarts,-access_clock_object_test)
…_simulated_load_reconfig_restarts,-access_clock_object_test)
Dkwcs
deleted the
sc-platfrom/fix-iota-benchmark-tests(test_simulated_load_reconfig_restarts,-access_clock_object_test)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
test_simulated_load_reconfig_restartspassed (green) without any changes.Links to any relevant issues
Fix #3852 .
Type of change
How the change has been tested
cargo simtest test_simulated_load_reconfig_restarts