feat(iota-framework): Display object extension #3861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriyr
added
the
sc-platform
valeriyr
changed the title
SystemDisplayCap
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
a3b474e to
fc6bdfa
Compare
miker83z
reviewed
Nov 4, 2024
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
1b9d004 to
cff774d
Compare
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
f4568b5 to
0fa27f6
Compare
lzpap
reviewed
Nov 5, 2024
lzpap
reviewed
Nov 5, 2024
crates/iota-framework/packages/iota-system/sources/iota_system_display.move
Outdated
Show resolved
Hide resolved
lzpap
reviewed
Nov 5, 2024
| } | ||
|
|
||
| /// Immutable borrows the value associated with the key in the extra fields. | ||
| public(package) fun borrow_extra_field<K: copy + drop + store, V: store>( |
There was a problem hiding this comment.
Two questions:
- Can you show me how would you implement a
x_y_z_object_display_exists()function on the authority state? This will be needed when we introduce creating/updating the displays with endofepoch, and I don't fully see how you'd do this, as it is not simply adoes an object with this ID exists in the state?type of query. - Assume there is an IotaSystemStateV2. How do you migrate the extra fields? You can't loop over them the way they are currently implemented, no? Would it make sense to use integer indexing so you can iterate over them since you know the bag size? And add some extra resolution table from index to type name.
There was a problem hiding this comment.
Assume there is an IotaSystemStateV2. How do you migrate the extra fields? You can't loop over them the way they are currently implemented, no? Would it make sense to use integer indexing so you can iterate over them since you know the bag size? And add some extra resolution table from index to type name.
We can hardcode the keys in the migration function that should exist at the previous version so this might not be an issue.
There was a problem hiding this comment.
Great questions:
- I was going to create such a function before marking the PR as ready to review 👍 We should also check if the
Displayof the specific version exists. - The extra fields are migrated just by moving a
Bagobject:
https://github.com/MystenLabs/sui/blob/69d3653419174917d8ffe667f230609970f9a544/crates/sui-framework/packages/sui-system/sources/sui_system_state_inner.move#L283
because all the fields are added asBagdynamic fields. Migration for each extra field should be done separately if it is required.
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
ad1d661 to
4860b6f
Compare
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
c6b5ed2 to
5235500
Compare
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
aeb0ba0 to
d1a7faf
Compare
valeriyr
force-pushed
the
sc-platform/issue-3087-display-object-ext
branch
from
d1a7faf to
8f82d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TODO
Links to any relevant issues
fixes #3087