Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): remove locked_balance from Balance #3886

Merged
merged 5 commits into from
Nov 5, 2024
Merged

fix(node): remove locked_balance from Balance #3886

merged 5 commits into from
Nov 5, 2024

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Nov 4, 2024

Description of change

It seems to be unused, and always initialized with default.

Links to any relevant issues

fixes #3866

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer requested review from a team as code owners November 4, 2024 19:45
@muXxer muXxer added the node Issues related to the Core Node team label Nov 4, 2024
@muXxer muXxer added this to the Testnet Launch v1.0.0-rc milestone Nov 4, 2024
@muXxer muXxer force-pushed the core-node/remove-locked-balance branch from 7beb3f4 to 9a2d843 Compare November 4, 2024 19:48
@muXxer muXxer requested review from a team as code owners November 4, 2024 20:28
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 130d8cc

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d1eexv8lg.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request has been deployed to Vercel.

Latest commit: 130d8cc

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9kt5us9mv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ Vercel Preview Deployment is ready!

View Preview

vivekjain23
vivekjain23 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 130d8cc

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-clcaa5onr.vercel.app

semenov-vladyslav
semenov-vladyslav previously requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request_add_stake_with_locked_coin function can also be removed.

docs/content/references/exchange-integration-guide.mdx
@@ -132,7 +132,6 @@ The response is a JSON object that includes the totalBalance for the address:
"coinType": "0x2::iota::IOTA",
"coinObjectCount": 40,
"totalBalance": 10000000000,
"lockedBalance": {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mention of LockedCoin in request_add_stake_with_locked_coin down below in this file which is also unused and should be removed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: f676794

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-62efj00ub.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: f676794

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-baiiz7fht.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: f676794

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-cz3ah6js3.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn alexsporn dismissed semenov-vladyslav’s stale review November 5, 2024 08:56

changes already fixed

@muXxer muXxer merged commit 112e777 into develop Nov 5, 2024
41 of 42 checks passed
@muXxer muXxer deleted the core-node/remove-locked-balance branch November 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekjain23 vivekjain23 vivekjain23 approved these changes

@bingyanglin bingyanglin bingyanglin approved these changes

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@alexsporn alexsporn alexsporn approved these changes

@piotrm50 piotrm50 piotrm50 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@semenov-vladyslav semenov-vladyslav Awaiting requested review from semenov-vladyslav

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation node Issues related to the Core Node team
Projects
None yet
Milestone
Testnet Launch v0.7.x-rc
Development

Successfully merging this pull request may close these issues.

Check if locked_balance can be removed from Balance in coin_api.rs
9 participants
@muXxer @begonaalvarezd @piotrm50 @alexsporn @semenov-vladyslav @DaughterOfMars @sergiupopescu199 @bingyanglin @vivekjain23