fix(core): CONFIG_OVERRIDE mutex poison #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoog
changed the title
thibault-martinez
approved these changes
Nov 7, 2024
Co-authored-by: DaughterOfMars <[email protected]>
DaughterOfMars
approved these changes
Nov 7, 2024
muXxer
requested changes
Nov 7, 2024
crates/iota-e2e-tests/tests/snapshots/snapshot_tests__body_fn.snap
Outdated
Show resolved
Hide resolved
Thoralf-M
approved these changes
Nov 11, 2024
|
This pull request has been deployed to Vercel. Latest commit: 7069a96 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-i0su9g1sx.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 7069a96 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9ybjmhki8.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 7069a96 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-50oohptaw.vercel.app |
muXxer
approved these changes
Nov 11, 2024
samuel-rufi
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR fixes a problem that was introduced in a previous PR (when attempting to fix a broken test).
Since we didn't test the consensus package, we didn't realize we introduced another problem.
Problem Description
The CONFIG_OVERRIDES need to be thread local as the lock can otherwise end up in a poisoned state.