Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooling-general): Update docs links #3980

Merged
merged 11 commits into from
Nov 12, 2024
Merged

refactor(tooling-general): Update docs links #3980

merged 11 commits into from
Nov 12, 2024

Conversation

marc2332
Copy link
Contributor

Closes #1934

@marc2332 marc2332 requested review from a team as code owners November 11, 2024 08:56
@marc2332 marc2332 self-assigned this Nov 11, 2024
@marc2332 marc2332 added the tooling Issues related to the Tooling team label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bc045c2

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-la5ysccpx.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bc045c2

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-4aswxuiic.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bc045c2

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-gz6nzf1at.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

brancoder
brancoder requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some places where wiki.iota.org is used
ex. https://wiki.iota.org/build/install
Should all of these links be updated in this PR?

sdk/create-dapp/templates/react-e2e-counter/README.md Outdated Show resolved Hide resolved
sdk/typescript/README.md Outdated Show resolved Hide resolved
sdk/typescript/package.json Outdated Show resolved Hide resolved
@marc2332 marc2332 requested review from miker83z, valeriyr and a team as code owners November 11, 2024 14:27
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c41dba7

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3tox97p68.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c41dba7

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gksn5uvpa.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c41dba7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-etfkga3eq.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0ce9e39

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-rmiq5zpru.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0ce9e39

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-fe18e3a4w.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0ce9e39

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hhtz5ug3l.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 47e78b5

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-mgcugfo2d.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 47e78b5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-1hi7duazv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 47e78b5

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-j9e9mvx5o.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

cpl121
cpl121 requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated FAQ_LINK in apps/wallet/src/shared/constants.ts

@marc2332 marc2332 mentioned this pull request Nov 12, 2024
Open
@marc2332 marc2332 requested review from cpl121 and jkrvivian November 12, 2024 10:51
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6d9df24

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fstd9od8f.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6d9df24

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-a32xw5egc.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 6d9df24

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-btwqub9ox.vercel.app

brancoder
brancoder approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 30d19d1

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-6pb4like6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 30d19d1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-p3imate0y.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 30d19d1

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ev41iy6g5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@begonaalvarezd begonaalvarezd merged commit f9f7c4f into develop Nov 12, 2024
40 of 41 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-general/update-docs-links branch November 12, 2024 14:40
begonaalvarezd pushed a commit that referenced this pull request Nov 12, 2024
@marc2332 @lucas-tortora @begonaalvarezd
refactor(tooling-general): Update docs links (#3980)
c6095d1 
* refactor(tooling-general): Update docs links

* Update sdk/typescript/package.json

Co-authored-by: Lucas Tortora <[email protected]>

* Update sdk/typescript/README.md

Co-authored-by: Lucas Tortora <[email protected]>

* chore: Update missing links

* chore: Update cafe links

* update validator_tool.md

* clean up

* remove old link

---------

Co-authored-by: Lucas Tortora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@cpl121 cpl121 cpl121 approved these changes

@brancoder brancoder brancoder approved these changes

@piotrm50 piotrm50 piotrm50 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@valeriyr valeriyr valeriyr approved these changes

@miker83z miker83z Awaiting requested review from miker83z

@jkrvivian jkrvivian Awaiting requested review from jkrvivian

Assignees

@marc2332 marc2332

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (tooling-sdk)]: Review READMEs and update links
9 participants
@marc2332 @valeriyr @thibault-martinez @begonaalvarezd @piotrm50 @jkrvivian @brancoder @lucas-tortora @cpl121