feat(wallet-dashboard): add staking confirmation screen #4034

VmMad · 2024-11-13T13:37:46Z

Fixes #3700

Depends on: #3832

…style-selected-stake # Conflicts: # apps/core/package.json # apps/core/src/components/index.ts # pnpm-lock.yaml

…pm-lock.yaml

…style-selected-stake # Conflicts: # apps/wallet-dashboard/app/layout.tsx

…into tooling-dashboard/style-selected-stake # Conflicts: # apps/wallet-dashboard/app/(protected)/staking/page.tsx

github-actions · 2024-11-13T13:39:35Z

This pull request has been deployed to Vercel.

Latest commit: fe7776a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-m97x57bh5.vercel.app

github-actions · 2024-11-13T13:39:39Z

This pull request has been deployed to Vercel.

Latest commit: fe7776a

✅ Preview: https://apps-ui-p06lurk6q-iota1.vercel.app

github-actions · 2024-11-13T13:39:43Z

This pull request has been deployed to Vercel.

Latest commit: fe7776a

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-4uy3u6cht.vercel.app

github-actions · 2024-11-13T13:40:08Z

This pull request has been deployed to Vercel.

Latest commit: fe7776a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-dd4r5a55d.vercel.app

apps/wallet-dashboard/components/Dialogs/Staking/views/ConfirmAndExit.tsx

github-actions · 2024-11-13T15:07:17Z

This pull request has been deployed to Vercel.

Latest commit: c578109

✅ Preview: https://apps-ui-8eelvkc6t-iota1.vercel.app

github-actions · 2024-11-13T15:08:05Z

This pull request has been deployed to Vercel.

Latest commit: c578109

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-1rqmzancc.vercel.app

github-actions · 2024-11-13T15:08:08Z

This pull request has been deployed to Vercel.

Latest commit: c578109

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-dapzgko1u.vercel.app

… feedback

…shboard/style-confirmation-screen

github-actions · 2024-11-25T09:01:41Z

This pull request has been deployed to Vercel.

Latest commit: ce38b84

✅ Preview: https://apps-ui-nlykh7dnd-iota1.vercel.app

github-actions · 2024-11-25T09:02:29Z

This pull request has been deployed to Vercel.

Latest commit: ce38b84

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-5mm54ax1u.vercel.app

github-actions · 2024-11-25T09:03:06Z

This pull request has been deployed to Vercel.

Latest commit: ce38b84

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-8jok503or.vercel.app

github-actions · 2024-11-25T09:03:23Z

This pull request has been deployed to Vercel.

Latest commit: ce38b84

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-660nere3l.vercel.app

cpl121

conflicts 🙏🏼

github-actions · 2024-11-25T17:41:49Z

This pull request has been deployed to Vercel.

Latest commit: 24ea08c

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-ad5rw6a4z.vercel.app

github-actions · 2024-11-25T17:42:30Z

This pull request has been deployed to Vercel.

Latest commit: 24ea08c

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6j384yf20.vercel.app

github-actions · 2024-11-25T17:42:31Z

This pull request has been deployed to Vercel.

Latest commit: 24ea08c

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-kh2cv1azy.vercel.app

github-actions · 2024-11-25T18:02:50Z

This pull request has been deployed to Vercel.

Latest commit: 8c14776

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-lmwne3qh4.vercel.app

github-actions · 2024-11-25T18:03:09Z

This pull request has been deployed to Vercel.

Latest commit: 8c14776

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-pgvtlb9xt.vercel.app

github-actions · 2024-11-25T18:03:30Z

This pull request has been deployed to Vercel.

Latest commit: 8c14776

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fzruvuylf.vercel.app

cpl121 · 2024-11-26T08:56:04Z

apps/wallet-dashboard/components/Dialogs/Staking/views/EnterAmountView.tsx

    selectedValidator: selectedValidatorAddress,
    onBack,
    onStake,
    gasBudget = 0,
    handleClose,
+    validatorApy,


where is this used?

cpl121 · 2024-11-26T09:01:02Z

apps/wallet-dashboard/components/Dialogs/Staking/StakeDialog.tsx

@@ -203,13 +201,14 @@ export function StakeDialog({
                            onNext={selectValidatorHandleNext}
                        />
                    )}
-                    {view === StakeDialogView.EnterAmount && (
+                    {view === StakeDialogView.EnterAmount && validatorApy && (


If validatorApy is not needed, there is no need to put it here either

cpl121 · 2024-11-26T09:01:58Z

apps/wallet-dashboard/components/Dialogs/Staking/StakeDialog.tsx

@@ -220,6 +219,18 @@ export function StakeDialog({
                            showActiveStatus
                        />
                    )}
+                    {view === StakeDialogView.TransactionDetails && (


just a comment: Why had you put it in the previous condition and not here?
... && validatorApy && (

right, cause there was no need for it to be always present, or it could be null

cpl121 · 2024-11-26T09:03:32Z

apps/wallet-dashboard/components/Dialogs/Staking/StakeDialog.tsx

-                        onSuccess(tx.digest);
-                    }
+                onSuccess: () => {
+                    setView?.(StakeDialogView.TransactionDetails);


why is setView optional in the props?

Not sure, wasn't made by this PR. I know previously there was a component were this DIalog was used without passing the setView prop

cpl121 · 2024-11-26T09:04:09Z

apps/core/src/utils/stake/getTotalValidatorStake.ts

+
+import { IotaValidatorSummary } from '@iota/iota-sdk/client';
+
+//TODO: verify this is the correct validator stake balance


comment unnecessary

this was in the code previously, are you sure we should delete it?

cpl121 · 2024-11-26T09:08:26Z

apps/core/src/utils/formatApy.ts

+// SPDX-License-Identifier: Apache-2.0
+
+export function formatApy(apy: number, isApyApproxZero: boolean = false): string {
+    return isApyApproxZero ? '~0%' : `${apy}%`;


Suggested change

return isApyApproxZero ? '~0%' : `${apy}%`;

return isApyApproxZero ? '~ 0%' : `${apy}%`;

cpl121 · 2024-11-26T09:11:44Z

apps/wallet-dashboard/components/Dialogs/Staking/views/FinishStaking.tsx

+
+            <LayoutFooter>
+                <div className="flex w-full">
+                    <Button type={ButtonType.Primary} fullWidth onClick={onConfirm} text="Finish" />


Suggested change

<Button type={ButtonType.Primary} fullWidth onClick={onConfirm} text="Finish" />

<Button type={ButtonType.Primary} fullWidth onClick={onConfirm} text="Confirm & Exit" />

github-actions · 2024-11-26T10:28:16Z

This pull request has been deployed to Vercel.

Latest commit: 026ee47

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-32clxuopb.vercel.app

github-actions · 2024-11-26T10:28:44Z

This pull request has been deployed to Vercel.

Latest commit: 026ee47

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-2vzmsu75b.vercel.app

github-actions · 2024-11-26T10:29:03Z

This pull request has been deployed to Vercel.

Latest commit: 026ee47

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-2rqveq56a.vercel.app

begonaalvarezd · 2024-11-26T11:59:58Z

Im very sorry but the original issue was wrong and this PR is not needed 💔

panteleymonchuk added 8 commits November 1, 2024 15:21

feat(tooling-dashboard): style selected stake

c925a99

feat(tooling-dashboard): add data to stake details page

1d8887e

feat(wallet-dashboard): remove extra memo.

a852fab

Merge remote-tracking branch 'origin/develop' into tooling-dashboard/…

8325b36

…style-selected-stake # Conflicts: # apps/core/package.json # apps/core/src/components/index.ts # pnpm-lock.yaml

feat(staking): refactor StakeDialog. Add new Layout component.

388058c

feat(tooling-core): add clsx dependency to package.json and update pn…

d8d03ac

…pm-lock.yaml

Merge remote-tracking branch 'origin/develop' into tooling-dashboard/…

1ff40ea

…style-selected-stake # Conflicts: # apps/wallet-dashboard/app/layout.tsx

Merge remote-tracking branch 'origin/tooling-epic/dashboard-styling' …

2c1adc9

…into tooling-dashboard/style-selected-stake # Conflicts: # apps/wallet-dashboard/app/(protected)/staking/page.tsx

VmMad added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Nov 13, 2024

VmMad self-assigned this Nov 13, 2024

VmMad requested review from a team as code owners November 13, 2024 13:37

VmMad linked an issue Nov 13, 2024 that may be closed by this pull request

Style staking flow finish screen #3700

Closed

cpl121 requested changes Nov 13, 2024

View reviewed changes

apps/wallet-dashboard/components/Dialogs/Staking/views/ConfirmAndExit.tsx Outdated Show resolved Hide resolved

feat(wallet-dashboard): manage view for dialog outside.

4d93394

feat(wallet-dashboard): join changes from PR 3854

8c17341

VmMad requested a review from cpl121 November 13, 2024 17:29

panteleymonchuk added 2 commits November 13, 2024 20:45

feat(wallet-dashboard): join enter amount screen from PR 3874

7f66cd0

feat(tooling-core): move validation schema

5932ed5

VmMad changed the base branch from tooling-dashboard/style-stake-amount to tooling-dashboard/style-selected-stake November 14, 2024 14:29

feat(wallet-dashboard): add staking confirmation screen

1507c81

VmMad force-pushed the tooling-dashboard/style-confirmation-screen branch from c578109 to 1507c81 Compare November 14, 2024 14:43

panteleymonchuk and others added 4 commits November 22, 2024 17:00

feat(wallet-dashboard): enhance transaction handling and improve user…

c8bbc90

… feedback

fix(wallet-dashboard): update onBack handler for improved navigation

af7f7dc

Merge branch 'develop' into tooling-dashboard/style-selected-stake

69bcf98

Merge branch 'tooling-dashboard/style-selected-stake' into tooling-da…

ce38b84

…shboard/style-confirmation-screen

VmMad requested a review from brancoder November 25, 2024 10:09

Base automatically changed from tooling-dashboard/style-selected-stake to develop November 25, 2024 16:20

cpl121 requested changes Nov 25, 2024

View reviewed changes

Merge branch 'develop' into tooling-dashboard/style-confirmation-screen

24ea08c

fix: update coin image

8c14776

VmMad requested a review from cpl121 November 25, 2024 18:07

cpl121 requested changes Nov 26, 2024

View reviewed changes

VmMad added 2 commits November 26, 2024 11:25

refactor: remove debris

9f7fe1d

Merge branch 'develop' into tooling-dashboard/style-confirmation-screen

026ee47

VmMad requested a review from cpl121 November 26, 2024 10:26

begonaalvarezd closed this Nov 26, 2024

begonaalvarezd deleted the tooling-dashboard/style-confirmation-screen branch November 26, 2024 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet-dashboard): add staking confirmation screen #4034

feat(wallet-dashboard): add staking confirmation screen #4034

VmMad commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

cpl121 left a comment

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

cpl121 Nov 26, 2024

cpl121 Nov 26, 2024

cpl121 Nov 26, 2024

VmMad Nov 26, 2024

cpl121 Nov 26, 2024

VmMad Nov 26, 2024 •

edited

Loading

cpl121 Nov 26, 2024

VmMad Nov 26, 2024

cpl121 Nov 26, 2024

cpl121 Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

begonaalvarezd commented Nov 26, 2024


		import { IotaValidatorSummary } from '@iota/iota-sdk/client';

		//TODO: verify this is the correct validator stake balance

	return isApyApproxZero ? '~0%' : `${apy}%`;
	return isApyApproxZero ? '~ 0%' : `${apy}%`;

	<Button type={ButtonType.Primary} fullWidth onClick={onConfirm} text="Finish" />
	<Button type={ButtonType.Primary} fullWidth onClick={onConfirm} text="Confirm & Exit" />

feat(wallet-dashboard): add staking confirmation screen #4034

feat(wallet-dashboard): add staking confirmation screen #4034

Conversation

VmMad commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 13, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

cpl121 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

github-actions bot commented Nov 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VmMad Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

begonaalvarezd commented Nov 26, 2024

VmMad commented Nov 13, 2024 •

edited

Loading

VmMad Nov 26, 2024 •

edited

Loading