Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devx): Navbar css and sidebar css #4055

Merged
merged 9 commits into from
Nov 17, 2024
Merged

fix(devx): Navbar css and sidebar css #4055

merged 9 commits into from
Nov 17, 2024

Conversation

lucas-tortora
Copy link
Contributor

Description of change

  • fixed the styling so the Navbar highlights the active section.
  • removed CSS that made the sidebar buggy on mobile

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner November 14, 2024 11:37
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@alexsporn alexsporn added the devx Issues related to the DevX team label Nov 14, 2024
@Dr-Electron
Copy link
Contributor

There is still stuff that bothers me in light mode (mobile) 😅
No highlighting on hover (or selection tbf)
sidebar highlighting

Hover of buttons/toggles:
Screenshot 2024-11-15 at 15 26 45
Screenshot 2024-11-15 at 15 27 08

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@Dr-Electron
Copy link
Contributor

Hover over sidebar items on mobile still doesn't work on my side:

hover over sidebar mobile

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Dr-Electron
Dr-Electron approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@Dr-Electron Dr-Electron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong text color on highlight

As I said this still doesn't work for me on mobile in light theme. But worst case we can merge and fix later

@lucas-tortora lucas-tortora merged commit caed599 into develop Nov 17, 2024
33 of 34 checks passed
@lucas-tortora lucas-tortora deleted the devx/fix-navbar branch November 17, 2024 23:06
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora added the documentation Improvements or additions to documentation label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekjain23 vivekjain23 vivekjain23 approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@Ginowine Ginowine Awaiting requested review from Ginowine

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation
Projects
Developer Experience
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucas-tortora @Dr-Electron @vivekjain23 @alexsporn