Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): add background to search suggestions #4162

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Nov 20, 2024

Fixes #4068

Depends on #4041

@VmMad VmMad added tooling Issues related to the Tooling team explorer Issues related to the Explorer labels Nov 20, 2024
@VmMad VmMad requested review from a team as code owners November 20, 2024 13:20
@VmMad VmMad changed the title feat(explorer): add backgrounds to the search suggestions feat(explorer): add background to search suggestions Nov 20, 2024
@VmMad VmMad linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2ff999a

✅ Preview: https://apps-ui-frxc96ns3-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2ff999a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-di0y0j0gw.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2ff999a

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6ggj1dv7c.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2ff999a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-lcmnquat6.vercel.app

Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you just add the backdrop-blur bg-neutral-100 dark:bg-neutral-10 class in line 165 in apps/ui-kit/src/lib/components/molecules/search/Search.tsx and fix all of them? now, it doesn't have a background, so adding this can resolve the issue in all the search bars with suggestions 💡

apps/explorer/src/components/header/Header.tsx Outdated Show resolved Hide resolved
@VmMad
Copy link
Member Author

VmMad commented Nov 21, 2024

why don't you just add the backdrop-blur bg-neutral-100 dark:bg-neutral-10 class in line 165 in apps/ui-kit/src/lib/components/molecules/search/Search.tsx and fix all of them? now, it doesn't have a background, so adding this can resolve the issue in all the search bars with suggestions 💡

To be able to make the suggestions background as we want. Like this the search bar looks like it has the same background blur as the navbar, which makes it seem more unified in my opnion

@evavirseda
Copy link
Contributor

why don't you just add the backdrop-blur bg-neutral-100 dark:bg-neutral-10 class in line 165 in apps/ui-kit/src/lib/components/molecules/search/Search.tsx and fix all of them? now, it doesn't have a background, so adding this can resolve the issue in all the search bars with suggestions 💡

To be able to make the suggestions background as we want. Like this the search bar looks like it has the same background blur as the navbar, which makes it seem more unified in my opnion

honestly, it makes more sense to me that all the search bars have the same style for the suggestions, but it's ok

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0138b6a

✅ Preview: https://apps-ui-5dkbhpo9p-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0138b6a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-prpl5tax9.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0138b6a

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-5h08k03sh.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0138b6a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hjy9s946f.vercel.app

@VmMad VmMad requested review from evavirseda and marc2332 November 21, 2024 13:28
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1f088c5

✅ Preview: https://apps-ui-913sez8al-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1f088c5

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-j09zx34du.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1f088c5

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-elebypupy.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1f088c5

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-c7ys1deca.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e89f84b

✅ Preview: https://apps-ui-mty68nyix-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e89f84b

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-6as69157g.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e89f84b

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jdh2gj3wp.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e89f84b

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hm84s92qt.vercel.app

@VmMad VmMad requested a review from evavirseda November 22, 2024 10:31
@msarcev msarcev merged commit 70f02cf into tooling-explorer/add-darkmode-support Nov 25, 2024
33 checks passed
@msarcev msarcev deleted the tooling-explorer/add-searchbar-background branch November 25, 2024 11:25
msarcev pushed a commit that referenced this pull request Nov 25, 2024
* feat(explorer): add theme switcher

* fix: add missing style to the icon

* fix: lint

* refactor: remove theme context from explorer

* feat(explorer): add background to search suggestions (#4162)

* feat(explorer): add backgrounds to the search suggestions

* refactor: add styles to search ui kit

* revert changes

* fix: remove unnecessary backdrop-blur

* fix: remove map

* feat(explorer): add darkmode support to epoch page (#4160)

* feat: polish darkmode

* fix format

* feat: update imports

* feat(explorer): improve darkmode colors for transaction page (#4158)

* feat(explorer): improve darkmode colors for transaction page

* feat: add button to the split panes

---------

Co-authored-by: evavirseda <[email protected]>
evavirseda added a commit that referenced this pull request Nov 26, 2024
* feat(explorer): add theme switcher

* fix: add missing style to the icon

* fix: lint

* feat(explorer): add missing darkmode colors to the homepage

* revert: imageicon

* revert: props unused

* refactor: remove theme context from explorer

* feat(explorer): add background to search suggestions (#4162)

* feat(explorer): add backgrounds to the search suggestions

* refactor: add styles to search ui kit

* revert changes

* fix: remove unnecessary backdrop-blur

* fix: remove map

---------

Co-authored-by: evavirseda <[email protected]>
cpl121 pushed a commit that referenced this pull request Nov 26, 2024
* feat(explorer): add theme switcher

* fix: add missing style to the icon

* fix: lint

* fix: add darkmode to footer

* refactor: remove theme context from explorer

* fix: remove debris and fix format

* feat(explorer): add background to search suggestions (#4162)

* feat(explorer): add backgrounds to the search suggestions

* refactor: add styles to search ui kit

* revert changes

* fix: remove unnecessary backdrop-blur

* fix: remove map

---------

Co-authored-by: JCNoguera <[email protected]>
cpl121 pushed a commit that referenced this pull request Nov 26, 2024
* feat(explorer): add theme switcher

* fix: add missing style to the icon

* fix: lint

* fix: autofilled input darkmode

* feat: add darkmode to loading indicator

* fix: add darkmode

* fix panel darkmode

* refactor: remove theme context from explorer

* feat: undo styles

* feat(explorer): add background to search suggestions (#4162)

* feat(explorer): add backgrounds to the search suggestions

* refactor: add styles to search ui kit

* revert changes

* fix: remove unnecessary backdrop-blur

* fix: remove map

* feat: update input colors

* fix use tailwind

* fix format

* minor fix

---------

Co-authored-by: JCNoguera <[email protected]>
Co-authored-by: Bran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add background to the search suggestions
4 participants