Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core, dashboard, wallet): move ValidatorLogo to apps/core and use it in Unstake Details #4475

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

refactor(core, dashboard, wallet): move ValidatorLogo to apps/core and use it in Unstake Details #4475

wants to merge 20 commits into from

Conversation

panteleymonchuk
Copy link
Contributor

Links to any relevant issues

fixes #3916

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 12, 2024
@panteleymonchuk panteleymonchuk requested a review from a team as a code owner December 12, 2024 14:28
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 608b1f7

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-5batly8gi.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 608b1f7

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-drnsua71h.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 608b1f7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-azhzd6iau.vercel.app

@panteleymonchuk panteleymonchuk marked this pull request as draft December 12, 2024 14:43
@panteleymonchuk panteleymonchuk marked this pull request as ready for review December 12, 2024 15:10
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ddee854

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3q2lmrylu.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ddee854

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-7cag42l12.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ddee854

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6i2112juw.vercel.app

@panteleymonchuk panteleymonchuk changed the title refactor(core, dashboard, wallet): Move ValidatorLogo to apps/core and use it in Unstake Details refactor(core, dashboard, wallet): move ValidatorLogo to apps/core and use it in Unstake Details Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1242e66

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-czjals7a5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1242e66

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-gt0javcwi.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1242e66

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fdycnghd6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39d01fe

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-nnkan30e5.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39d01fe

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-a3blstewm.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39d01fe

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-4zw2cgrud.vercel.app

marc2332
marc2332 requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove validatorLogo.interfaces.ts

apps/core/src/components/Validator.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: aab3a17

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-n8hhdfi5d.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fe9ca29

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3fpv7v9s2.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fe9ca29

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-6dge0yw3a.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fe9ca29

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fbxspdjjh.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fabbaa7

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3m8885hhe.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fabbaa7

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ji33lz5p4.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fabbaa7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-7fxfra67i.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1b1d1aa

✅ Preview: https://apps-backend-l80xypm3s-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1b1d1aa

✅ Preview: https://rebased-explorer-1nin85erq-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1b1d1aa

✅ Preview: https://wallet-dashboard-cwqywikcz-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 300a8a9

✅ Preview: https://apps-backend-9yxxenjx8-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 300a8a9

✅ Preview: https://rebased-explorer-c6j32od1n-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 300a8a9

✅ Preview: https://wallet-dashboard-p5dhr27u8-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8e650d6

✅ Preview: https://rebased-explorer-n1wobs1yd-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8e650d6

✅ Preview: https://apps-backend-pgl0wwf4w-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8e650d6

✅ Preview: https://wallet-dashboard-bt54v5rhd-iota1.vercel.app

@panteleymonchuk
Merge remote-tracking branch 'origin/develop' into tooling/move-valid…
9fad775 
…ator-logo

# Conflicts:
#	apps/wallet-dashboard/components/Dialogs/unstake/views/UnstakeTimelockedObjectsView.tsx
#	apps/wallet-dashboard/components/Dialogs/unstake/views/UnstakeView.tsx
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9fad775

✅ Preview: https://apps-backend-9e0uxysgn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9fad775

✅ Preview: https://rebased-explorer-fny9y2xy2-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9fad775

✅ Preview: https://wallet-dashboard-o9yycn17i-iota1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@evavirseda evavirseda evavirseda approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ValidatorLogo to apps/core and use it in Unstake Details
5 participants
@panteleymonchuk @marc2332 @evavirseda @cpl121 @brancoder