Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-data-ingestion-core): add README.md #4570

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

sergiupopescu199
Copy link
Contributor

Description of change

Investigate the iota-data-ingestion-core crate and provide a README.md which explore how it works and its use cases

Links to any relevant issues

fixes #1450

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code

@sergiupopescu199 sergiupopescu199 added sc-platform Issues related to the Smart Contract Platform group. infrastructure Issues related to the Infrastructure Team labels Dec 19, 2024
@sergiupopescu199 sergiupopescu199 force-pushed the sc-platform/issue-1450 branch 3 times, most recently from f87059a to 87708df Compare December 19, 2024 16:01
@sergiupopescu199 sergiupopescu199 marked this pull request as ready for review December 20, 2024 10:33
@sergiupopescu199 sergiupopescu199 requested a review from a team as a code owner December 20, 2024 10:33
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @sergiupopescu199 . I left a few minor suggestions only that might be helpful to implement.

crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Show resolved Hide resolved
crates/iota-data-ingestion-core/README.md Outdated Show resolved Hide resolved
@sergiupopescu199 sergiupopescu199 merged commit 3baf0e2 into develop Jan 15, 2025
42 checks passed
@sergiupopescu199 sergiupopescu199 deleted the sc-platform/issue-1450 branch January 15, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (Infrastructure)]: Review the data ingestion framework (iota-data-ingestion-core)
5 participants