Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add notes about indexer in rpc specs #4584

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Dr-Electron
Copy link
Contributor

Description of change

Some RPC endpoints are only available on indexer. So I added a note and changed the text where needed.

Links to any relevant issues

Fixes #4565.

Type of change

  • Documentation Fix

How the change has been tested

Run locally

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron Dr-Electron requested review from a team as code owners December 20, 2024 12:22
@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 20, 2024
@Dr-Electron Dr-Electron requested a review from a team December 20, 2024 12:22
@@ -14,7 +14,7 @@ use jsonrpsee::{core::RpcResult, proc_macros::rpc};
#[open_rpc(namespace = "iotax", tag = "Extended API")]
#[rpc(server, client, namespace = "iotax")]
pub trait ExtendedApi {
/// Return a list of epoch info
/// Return a list of epoch info. Exclusively served by the indexer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Return a list of epoch info. Exclusively served by the indexer
/// Return a list of epoch info. Exclusively served by the indexer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And below as well please 🙏

Copy link
Contributor

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @DaughterOfMars 's comments, LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Issues related to the DevX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document indexer-only RPC calls
6 participants