-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): add notes about indexer in rpc specs #4584
base: develop
Are you sure you want to change the base?
Conversation
@@ -14,7 +14,7 @@ use jsonrpsee::{core::RpcResult, proc_macros::rpc}; | |||
#[open_rpc(namespace = "iotax", tag = "Extended API")] | |||
#[rpc(server, client, namespace = "iotax")] | |||
pub trait ExtendedApi { | |||
/// Return a list of epoch info | |||
/// Return a list of epoch info. Exclusively served by the indexer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Return a list of epoch info. Exclusively served by the indexer | |
/// Return a list of epoch info. Exclusively served by the indexer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And below as well please 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides @DaughterOfMars 's comments, LGTM :)
Description of change
Some RPC endpoints are only available on indexer. So I added a note and changed the text where needed.
Links to any relevant issues
Fixes #4565.
Type of change
How the change has been tested
Run locally
Change checklist