Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts-sdk): Update typography light theme line height #4589

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(ts-sdk): Update typography light theme line height #4589

merged 3 commits into from
Dec 23, 2024

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Dec 20, 2024 •
edited
Loading

Closes #4590

Its now the same one as we have in the dark theme

@marc2332 marc2332 added the tooling Issues related to the Tooling team label Dec 20, 2024
@marc2332 marc2332 self-assigned this Dec 20, 2024
@marc2332 marc2332 marked this pull request as ready for review December 20, 2024 14:25
@marc2332 marc2332 requested a review from a team as a code owner December 20, 2024 14:25
Dr-Electron
Dr-Electron approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. when fix the real thing tho? :trollface:

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 276c012

✅ Preview: https://apps-backend-osvt5s7d4-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 276c012

✅ Preview: https://rebased-explorer-pe5f9ja7y-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 276c012

✅ Preview: https://wallet-dashboard-gn2ufx6nx-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 833c10d

✅ Preview: https://apps-backend-nr3tv2635-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 833c10d

✅ Preview: https://rebased-explorer-66rfeoeeb-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 833c10d

✅ Preview: https://wallet-dashboard-5q1830xm4-iota1.vercel.app

@begonaalvarezd begonaalvarezd changed the title fix(sdk): Update typography light theme line height fix(ts-sdk): Update typography light theme line height Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b65b842

✅ Preview: https://apps-backend-k3odeqh75-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b65b842

✅ Preview: https://rebased-explorer-2thhhlx0w-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b65b842

✅ Preview: https://wallet-dashboard-n5qoxjqbv-iota1.vercel.app

@begonaalvarezd begonaalvarezd merged commit 04e84b1 into develop Dec 23, 2024
35 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-sdk/update-typography-light-theme-line-height branch December 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@marc2332 marc2332

Labels
tooling Issues related to the Tooling team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Typography styling in both dark and light dapp-kit themes
4 participants
@marc2332 @begonaalvarezd @Dr-Electron @evavirseda