Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooling): remove unnecessary import React from 'react' #4612

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4371

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner December 24, 2024 08:23
@evavirseda evavirseda self-assigned this Dec 24, 2024
@github-actions github-actions bot added the explorer Issues related to the Explorer label Dec 24, 2024
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Dec 24, 2024
@evavirseda evavirseda removed the explorer Issues related to the Explorer label Dec 24, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a653fee

✅ Preview: https://apps-ui-5objsv8ez-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a653fee

✅ Preview: https://apps-backend-ozs6ie861-iota1.vercel.app

@github-actions github-actions bot added the explorer Issues related to the Explorer label Dec 24, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bd2d796

✅ Preview: https://apps-ui-cz2hlhinn-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bd2d796

✅ Preview: https://apps-backend-9tn3n5bc2-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://apps-ui-q38iiigbw-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://apps-backend-32gxqr1ij-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://rebased-explorer-j6a379rxx-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: ac22dd3

✅ Preview: https://wallet-dashboard-cd5lhgkia-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://apps-backend-pxuzcnd7e-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://apps-ui-plzek32c4-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://rebased-explorer-cfm09l9gd-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f728065

✅ Preview: https://wallet-dashboard-jmmcuaonk-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://apps-ui-6mjse228v-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://rebased-explorer-4jd6ilwew-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://apps-backend-ltq76etcv-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42625d3

✅ Preview: https://wallet-dashboard-g36svylby-iota1.vercel.app

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still more import react in the codebase, note that not all can be removed because some are necessary like in the dapps and the SDK

image

@github-actions github-actions bot added the apps-ui-kit Issues related to the Apps UI Kit label Dec 26, 2024
@github-actions github-actions bot added wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 26, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9ac5497

✅ Preview: https://apps-ui-e9mkm8iwc-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9ac5497

✅ Preview: https://apps-backend-mfm2uiw7i-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9ac5497

✅ Preview: https://rebased-explorer-4pdammbno-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9ac5497

✅ Preview: https://wallet-dashboard-p6rqhdy5x-iota1.vercel.app

@github-actions github-actions bot added the apps-backend Issues related to the Apps Backend label Dec 26, 2024
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0a0b467

✅ Preview: https://apps-ui-pjqvbadw7-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0a0b467

✅ Preview: https://apps-backend-qa5gbxh5b-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0a0b467

✅ Preview: https://rebased-explorer-l8lj6lisz-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0a0b467

✅ Preview: https://wallet-dashboard-dar0idyv5-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://apps-ui-bom2womjj-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://rebased-explorer-ek8ifk2z9-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://apps-backend-f6v753bx0-iota1.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d4610f8

✅ Preview: https://wallet-dashboard-ll4dlsx1l-iota1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps-backend Issues related to the Apps Backend apps-ui-kit Issues related to the Apps UI Kit explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary import React from 'react'
3 participants